-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WebJobs][EventHubsExtension] Fix metrics when azure checkpoint container does not exist #43213
Conversation
/azp run net - eventhub - functions - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run net - eventhub - functions - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
Change looks good. It appears some tests need to be fixed up to account for the new behavior. Given that, it may be helpful to add a test or so for this specific scenario to confirm the change has the intended effect. |
Removing approval until test runs are clean.
/azp run net - eventhub - functions - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
@jsquire, I fixed the unit tests and run azure pipeline - it seems the errors are not PR related. |
Can you try fetching/rebasing on |
22c7ab4
to
e87b475
Compare
/azp run net - eventhub - functions - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
This isn't you being out of sync. Because the CI pipeline got disabled, there was no API export done. I've got that going in another PR but it'll block until then. I'm going to bypass checks so that this can merge and be included in this month's release. |
/check-enforcer override |
Hrmm... looks like it is still blocked and I can't bypass. Please run the ExportApi script or steal the export from here and include it. That will unblock you. |
…iner does not exist (Azure#43213)
If the container "azure-webjobs-eventhub" does not exist - scaling logic is not able to detect new EH messages.