Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebJobs][EventHubsExtension] Fix metrics when azure checkpoint container does not exist #43213

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

alrod
Copy link
Member

@alrod alrod commented Apr 4, 2024

If the container "azure-webjobs-eventhub" does not exist - scaling logic is not able to detect new EH messages.

@Azure Azure deleted a comment from azure-pipelines bot Apr 5, 2024
@Azure Azure deleted a comment from azure-pipelines bot Apr 5, 2024
@Azure Azure deleted a comment from azure-pipelines bot Apr 5, 2024
@jsquire
Copy link
Member

jsquire commented Apr 5, 2024

/azp run net - eventhub - functions - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Azure Azure deleted a comment from azure-pipelines bot Apr 5, 2024
@jsquire
Copy link
Member

jsquire commented Apr 5, 2024

/azp run net - eventhub - functions - ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jsquire
jsquire previously approved these changes Apr 5, 2024
@jsquire
Copy link
Member

jsquire commented Apr 5, 2024

Change looks good. It appears some tests need to be fixed up to account for the new behavior. Given that, it may be helpful to add a test or so for this specific scenario to confirm the change has the intended effect.

@jsquire jsquire dismissed their stale review April 5, 2024 13:55

Removing approval until test runs are clean.

@alrod
Copy link
Member Author

alrod commented Apr 5, 2024

/azp run net - eventhub - functions - ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alrod alrod requested a review from jsquire April 6, 2024 15:03
@alrod
Copy link
Member Author

alrod commented Apr 6, 2024

@jsquire, I fixed the unit tests and run azure pipeline - it seems the errors are not PR related.

@jsquire
Copy link
Member

jsquire commented Apr 8, 2024

@jsquire, I fixed the unit tests and run azure pipeline - it seems the errors are not PR related.

Can you try fetching/rebasing on main? Something is out of sync in your working directory.

@alrod alrod force-pushed the user/alrod/eh-fix-empty-checkpoint-container branch from 22c7ab4 to e87b475 Compare April 8, 2024 17:38
@alrod
Copy link
Member Author

alrod commented Apr 8, 2024

/azp run net - eventhub - functions - ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jsquire
Copy link
Member

jsquire commented Apr 8, 2024

@jsquire, I fixed the unit tests and run azure pipeline - it seems the errors are not PR related.

This isn't you being out of sync. Because the CI pipeline got disabled, there was no API export done. I've got that going in another PR but it'll block until then. I'm going to bypass checks so that this can merge and be included in this month's release.

@jsquire
Copy link
Member

jsquire commented Apr 8, 2024

/check-enforcer override

@jsquire
Copy link
Member

jsquire commented Apr 8, 2024

Hrmm... looks like it is still blocked and I can't bypass. Please run the ExportApi script or steal the export from here and include it. That will unblock you.

@alrod alrod merged commit 3c07c4f into main Apr 9, 2024
15 of 17 checks passed
@alrod alrod deleted the user/alrod/eh-fix-empty-checkpoint-container branch April 9, 2024 01:30
christothes pushed a commit to christothes/azure-sdk-for-net that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants