Skip to content

Conversation

@payiAzure
Copy link
Contributor

@payiAzure payiAzure commented Apr 10, 2018

Description

Fix an small issue in Management.Sql sdk for customization elastic pool model in previous PR (#4171). Simple fix, no other changes. Related rest-api PR: (Azure/azure-rest-api-specs#2734)

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@payiAzure
Copy link
Contributor Author

@dsgouda Hi Deepak, Can you please review this PR? We found an issue with the previous merged Management.Sql SDK, and this one fix the issue. We want to checkin this asap before the new SDK version 1.14.0-preview is published. Thanks!

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda
Copy link
Contributor

dsgouda commented Apr 10, 2018

@payiAzure if your package has been published already, you will need to bump the version before you publish

@dsgouda dsgouda merged commit d0e5108 into Azure:psSdkJson6 Apr 10, 2018
@payiAzure
Copy link
Contributor Author

@dsgouda Thanks Deepak! The package has not been published yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants