Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

astro dot net sdk beta #41828

Merged
merged 19 commits into from
Apr 28, 2024
Merged

Conversation

banggaurav
Copy link
Member

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

Copy link

github-actions bot commented Feb 7, 2024

Thank you for your contribution @banggaurav! We will review the pull request and get back to you soon.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Feb 7, 2024
Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@banggaurav :

Your account is missing the required public GitHub organizations and write permissions. We'll need to correct this before the PR can move forward. Please review the Azure SDK onboarding documentation and use the below Teams channel for assistance.

You'll also need to add entries to CODEOWNERS for the "Astronomer" label, one for PR reviewers and one for the support contacts. Please follow the existing format, which will look something like:

# PRLabel: %Astronomer
# ServiceLabel: %Astronomer
/sdk/deviceregistry/Azure.ResourceManager.Astro/    @person @person

.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Account now has the correct public GitHub organizations, but still lacks the required write permission to the repository.

.github/CODEOWNERS Outdated Show resolved Hide resolved
@ArthurMa1978
Copy link
Member

/azp run prepare-pipelines

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Azure Azure deleted a comment from azure-pipelines bot Apr 28, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.ResourceManager.Astro

@Azure Azure deleted a comment from azure-pipelines bot Apr 28, 2024
@Azure Azure deleted a comment from azure-pipelines bot Apr 28, 2024
@ArthurMa1978
Copy link
Member

/azp run net - astronomer - mgmt

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ArthurMa1978 ArthurMa1978 dismissed jsquire’s stale review April 28, 2024 06:36

Gaurav has got the write permission

@ArthurMa1978 ArthurMa1978 merged commit 82e8d8f into Azure:main Apr 28, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants