Skip to content

Conversation

@gucalder
Copy link
Contributor

Description

The commit in the Swagger specs repo with the bug fix is: 34e1432


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@dsgouda dsgouda self-assigned this Mar 15, 2018
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pull down the latest changes from upstream and run

  • msbuild build.proj
  • msbuild build.proj /t:Build /p:Scope=SDKs\Monitor
  • generate.cmd
    Please commit the artifacts generated by these steps

<Description>Microsoft Azure Monitor Library</Description>
<AssemblyName>Microsoft.Azure.Management.Monitor</AssemblyName>
<Version>0.19.0-preview</Version>
<Version>0.19.1-preview</Version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a breaking change, please bump this to 0.20.0-preview

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bug fix (issue #2655 from Swagger): any call that used the top argument returned BadRequest.

@gucalder
Copy link
Contributor Author

I followed the steps suggested above in that order, but no artifact was generated.

@dsgouda
Copy link
Contributor

dsgouda commented Mar 15, 2018

You might want to do a git clean -xdf and start over again since this will re-install the latest build tools. A txt file should be generated/modified when you go through these steps.

@gucalder
Copy link
Contributor Author

Only a file called "_metadata/monitor_resource-manager.txt" is generated. Is that the one?

@dsgouda
Copy link
Contributor

dsgouda commented Mar 15, 2018

Yes, that's the one.

@gucalder
Copy link
Contributor Author

Cool. Thanks!

@gucalder
Copy link
Contributor Author

This is a failed test from KeyVault:

c:\workspace\NetCore-SdkCI\tools\SdkBuildTools\targets\common.targets(189,5): error MSB3073: The command "dotnet test -f netcoreapp1.1 c:\workspace\NetCore-SdkCI\src\SDKs\KeyVault\dataPlane\Microsoft.Azure.KeyVault.Tests\Microsoft.Azure.KeyVault.Tests.csproj -l trx;LogFileName=c:\workspace\NetCore-SdkCI\TestResults\netCore11\Microsoft.Azure.KeyVault.Tests.trx " exited with code 1. [c:\workspace\NetCore-SdkCI\build.proj]

@dsgouda
Copy link
Contributor

dsgouda commented Mar 16, 2018

@azuresdkci retest this please

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants