-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[Monitor] Fixing bug #2655: the top argument of the Metrics API must be a integer instead of a double #4134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…must be a integer instead of a double
dsgouda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please pull down the latest changes from upstream and run
- msbuild build.proj
- msbuild build.proj /t:Build /p:Scope=SDKs\Monitor
- generate.cmd
Please commit the artifacts generated by these steps
| <Description>Microsoft Azure Monitor Library</Description> | ||
| <AssemblyName>Microsoft.Azure.Management.Monitor</AssemblyName> | ||
| <Version>0.19.0-preview</Version> | ||
| <Version>0.19.1-preview</Version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a breaking change, please bump this to 0.20.0-preview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bug fix (issue #2655 from Swagger): any call that used the top argument returned BadRequest.
… into psSdkJson6
|
I followed the steps suggested above in that order, but no artifact was generated. |
|
You might want to do a |
|
Only a file called "_metadata/monitor_resource-manager.txt" is generated. Is that the one? |
|
Yes, that's the one. |
|
Cool. Thanks! |
|
This is a failed test from KeyVault: c:\workspace\NetCore-SdkCI\tools\SdkBuildTools\targets\common.targets(189,5): error MSB3073: The command "dotnet test -f netcoreapp1.1 c:\workspace\NetCore-SdkCI\src\SDKs\KeyVault\dataPlane\Microsoft.Azure.KeyVault.Tests\Microsoft.Azure.KeyVault.Tests.csproj -l trx;LogFileName=c:\workspace\NetCore-SdkCI\TestResults\netCore11\Microsoft.Azure.KeyVault.Tests.trx " exited with code 1. [c:\workspace\NetCore-SdkCI\build.proj] |
|
@azuresdkci retest this please |
dsgouda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
The commit in the Swagger specs repo with the bug fix is: 34e1432
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.