Skip to content

[Storage][DataMovement] Change test event asserts to CollectionAssert #36553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2023
Merged

[Storage][DataMovement] Change test event asserts to CollectionAssert #36553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 26 additions & 16 deletions sdk/storage/Azure.Storage.DataMovement/tests/TestEventsRaised.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,9 +184,11 @@ public void AssertContainerCompletedCheck(int transferCount)
Assert.IsEmpty(SkippedEvents);
// TODO: Reenable check: https://github.com/Azure/azure-sdk-for-net/issues/35976
// Assert.AreEqual(transferCount, SingleCompletedEvents.Count);
Assert.AreEqual(2, StatusEvents.Count);
Assert.AreEqual(StorageTransferStatus.InProgress, StatusEvents.First().StorageTransferStatus);
Assert.AreEqual(StorageTransferStatus.Completed, StatusEvents.ElementAt(1).StorageTransferStatus);
CollectionAssert.AreEqual(
new StorageTransferStatus[] {
StorageTransferStatus.InProgress,
StorageTransferStatus.Completed },
StatusEvents.Select(e => e.StorageTransferStatus));
}

/// <summary>
Expand All @@ -201,10 +203,12 @@ public void AssertContainerCompletedWithFailedCheck(int expectedFailureCount)
{
Assert.AreEqual(expectedFailureCount, FailedEvents.Count);
Assert.IsEmpty(SkippedEvents);
Assert.AreEqual(3, StatusEvents.Count);
Assert.AreEqual(StorageTransferStatus.InProgress, StatusEvents.First().StorageTransferStatus);
Assert.AreEqual(StorageTransferStatus.CancellationInProgress, StatusEvents.ElementAt(1).StorageTransferStatus);
Assert.AreEqual(StorageTransferStatus.CompletedWithFailedTransfers, StatusEvents.ElementAt(2).StorageTransferStatus);
CollectionAssert.AreEqual(
new StorageTransferStatus[] {
StorageTransferStatus.InProgress,
StorageTransferStatus.CancellationInProgress,
StorageTransferStatus.CompletedWithFailedTransfers },
StatusEvents.Select(e => e.StorageTransferStatus));
}

/// <summary>
Expand All @@ -219,9 +223,11 @@ public void AssertContainerCompletedWithFailedCheckContinue(int expectedFailureC
{
Assert.AreEqual(expectedFailureCount, FailedEvents.Count);
Assert.IsEmpty(SkippedEvents);
Assert.AreEqual(2, StatusEvents.Count);
Assert.AreEqual(StorageTransferStatus.InProgress, StatusEvents.First().StorageTransferStatus);
Assert.AreEqual(StorageTransferStatus.CompletedWithFailedTransfers, StatusEvents.ElementAt(1).StorageTransferStatus);
CollectionAssert.AreEqual(
new StorageTransferStatus[] {
StorageTransferStatus.InProgress,
StorageTransferStatus.CompletedWithFailedTransfers },
StatusEvents.Select(e => e.StorageTransferStatus));
}

/// <summary>
Expand All @@ -235,18 +241,22 @@ public void AssertContainerCompletedWithSkippedCheck(int expectedSkipCount)
{
AssertUnexpectedFailureCheck();
Assert.AreEqual(expectedSkipCount, SkippedEvents.Count);
Assert.AreEqual(2, StatusEvents.Count);
Assert.AreEqual(StorageTransferStatus.InProgress, StatusEvents.First().StorageTransferStatus);
Assert.AreEqual(StorageTransferStatus.CompletedWithSkippedTransfers, StatusEvents.ElementAt(1).StorageTransferStatus);
CollectionAssert.AreEqual(
new StorageTransferStatus[] {
StorageTransferStatus.InProgress,
StorageTransferStatus.CompletedWithSkippedTransfers },
StatusEvents.Select(e => e.StorageTransferStatus));
}

public void AssertPausedCheck()
{
AssertUnexpectedFailureCheck();
Assert.IsEmpty(SkippedEvents);
Assert.AreEqual(2, StatusEvents.Count);
Assert.AreEqual(StorageTransferStatus.InProgress, StatusEvents.First().StorageTransferStatus);
Assert.AreEqual(StorageTransferStatus.Paused, StatusEvents.ElementAt(1).StorageTransferStatus);
CollectionAssert.AreEqual(
new StorageTransferStatus[] {
StorageTransferStatus.InProgress,
StorageTransferStatus.Paused },
StatusEvents.Select(e => e.StorageTransferStatus));
}

/// <summary>
Expand Down