Bump up version for nuget release for Azure Management Network #3543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eways - Retake Fix parameter name and structure for radius server setting for VpnGateways
Bump up version for nuget release for Azure Management Network
… into psSdkJson6
shahabhijeet
suggested changes
Aug 2, 2017
| @@ -4,11 +4,11 @@ | |||
| <PackageId>Microsoft.Azure.Management.Network</PackageId> | |||
| <Description>Provides management capabilities for Network services.</Description> | |||
| <AssemblyName>Microsoft.Azure.Management.Network</AssemblyName> | |||
| <VersionPrefix>12.0.0-preview</VersionPrefix> | |||
| <VersionPrefix>12.0.1-preview</VersionPrefix> | |||
There was a problem hiding this comment.
@ritwikbasu remove this and replace here with < version > but don't keep both tags.
Also move the < version > tag to the top property group and not the propertygroup below.
Also you need to bump up the assembly version in AssemblyInfo.cs
There was a problem hiding this comment.
Resolved in commit update
shahabhijeet
suggested changes
Aug 2, 2017
| [assembly: AssemblyVersion("12.0.0.0")] | ||
| [assembly: AssemblyFileVersion("12.0.0.0")] | ||
| [assembly: AssemblyVersion("12.0.1.0")] | ||
| [assembly: AssemblyFileVersion("12.0.1.0")] |
There was a problem hiding this comment.
@ritwikbasu can you revert the file version, you don't need to update minor version updates to your file version.
Will create bunch of issue when you have dot releases
shahabhijeet
approved these changes
Aug 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.