-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump up version for nuget release for Azure Management Network #3543
Conversation
…eways - Retake Fix parameter name and structure for radius server setting for VpnGateways
Bump up version for nuget release for Azure Management Network
… into psSdkJson6
@@ -4,11 +4,11 @@ | |||
<PackageId>Microsoft.Azure.Management.Network</PackageId> | |||
<Description>Provides management capabilities for Network services.</Description> | |||
<AssemblyName>Microsoft.Azure.Management.Network</AssemblyName> | |||
<VersionPrefix>12.0.0-preview</VersionPrefix> | |||
<VersionPrefix>12.0.1-preview</VersionPrefix> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ritwikbasu remove this and replace here with < version > but don't keep both tags.
Also move the < version > tag to the top property group and not the propertygroup below.
Also you need to bump up the assembly version in AssemblyInfo.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved in commit update
[assembly: AssemblyVersion("12.0.0.0")] | ||
[assembly: AssemblyFileVersion("12.0.0.0")] | ||
[assembly: AssemblyVersion("12.0.1.0")] | ||
[assembly: AssemblyFileVersion("12.0.1.0")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ritwikbasu can you revert the file version, you don't need to update minor version updates to your file version.
Will create bunch of issue when you have dot releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK.