Disable building snippets for more libraries #33989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heaths
requested review from
vicancy,
JialinXin,
christothes,
jsquire,
JoshLove-msft,
sameergMS,
NiveditJain,
drwill-ms,
timtay-microsoft,
abhipsaMisra,
digimaun,
brycewang-microsoft,
andyk-ms,
johngallardo,
abhinav-ghai,
Aashish93-stack,
sjiherzig,
nisha-bhatia,
ShivangiReja,
AlexanderSher and
pallavit
as code owners
ghost
added
App Configuration
heaths
requested review from
m-nash
and removed request for
tg-msft,
Drewm3,
jfggdl,
grizzlytheodore,
ahamad-MS,
annelo-msft,
wonner,
Kishp01,
madewithsmiles,
jaschrep-msft,
seanmcc-msft,
amnguye,
Sandido,
haagha,
MS-syh2qs,
amjads1 and
dkulkarni-ms
jsquire
approved these changes
Feb 8, 2023
christothes
reviewed
Feb 8, 2023
m-nash
approved these changes
Feb 8, 2023
|
@christothes discovered the source of the breaks on macOS (or maybe just because that was the only agent that exercised those tests) and is prepping a separate PR now. As such, overriding this one since every other test passed. |
|
/check-enforcer override |
heaths
added a commit
to heaths/azure-sdk-for-net
that referenced
this pull request
Feb 8, 2023
Should've been part of Azure#33998, but that was merged before snippets were disabled in Azure#33989.
heaths
added a commit
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #33969