Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LangVersion in individual projects #33890

Merged
merged 3 commits into from
Feb 3, 2023

Conversation

AlexanderSher
Copy link
Contributor

No description provided.

@ghost ghost added Event Hubs KeyVault Service Bus Storage Storage Service (Queues, Blobs, Files) Tables labels Feb 3, 2023
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@pallavit
Copy link
Contributor

pallavit commented Feb 3, 2023

Can/should we plan to add an analyzer rule to check for this?

@AlexanderSher
Copy link
Contributor Author

Can/should we plan to add an analyzer rule to check for this?

@pallavit You mean check that internal projects don't define lang version? From time to time it can be useful, cause new versions of language can introduce breaking changes that we may have no capacity to fix immediately.

@jsquire
Copy link
Member

jsquire commented Feb 3, 2023

Can/should we plan to add an analyzer rule to check for this?

I don't think so. Individual packages should be able to deviate if needed. Particularly this is useful when you need to back-pin a specific library to work around compiler issues.

@AlexanderSher AlexanderSher merged commit c3549fb into Azure:main Feb 3, 2023
@heaths
Copy link
Member

heaths commented Feb 3, 2023

Can/should we plan to add an analyzer rule to check for this?

@pallavit You mean check that internal projects don't define lang version? From time to time it can be useful, cause new versions of language can introduce breaking changes that we may have no capacity to fix immediately.

As long as new syntactic language features can be built by the SDK in the root global.json. Language features that require a newer SDK should already fail the build since we target netstandard2.0 at least. We do require public APIs to be the same across TFMs for now, and I have #33433 on my plate to hook up to help ensure that since the .NET team already has a solution for this (as well as backcompat checks - a replacement for what we're using now).

richardcho-msft pushed a commit to richardcho-msft/azure-sdk-for-net that referenced this pull request Feb 6, 2023
* Update LangVersion in individual projects

* Restore LangVersion tag in sample project

* Address PR comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants