Skip to content

Conversation

btpemercier
Copy link
Contributor

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Jan 13, 2023
@ghost
Copy link

ghost commented Jan 13, 2023

Thank you for your contribution @btpemercier! We will review the pull request and get back to you soon.

@ghost ghost added the Community Contribution Community members are working on the issue label Jan 13, 2023
@btpemercier
Copy link
Contributor Author

@microsoft-github-policy-service agree

@jsquire jsquire requested a review from lmolkova January 13, 2023 14:54
@jsquire
Copy link
Member

jsquire commented Jan 13, 2023

@lmolkova, @JoshLove-msft: Would you please review?

@jsquire jsquire requested a review from JoshLove-msft January 13, 2023 14:54
@lmolkova
Copy link

/cc @vishweshbankwar to make sure it aligns with Monitor plans.

Copy link
Contributor

@vishweshbankwar vishweshbankwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Approving the OTel part)

fix: code review revert unwanted modification
@TimothyMothra TimothyMothra merged commit 06987ac into Azure:main Jan 18, 2023
@btpemercier btpemercier deleted the feature/upgrade_telemetry branch January 19, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants