feat(dataplane): unify abstract base class #32661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now dataplane does not default to abstract for base classes of polymorphic sets. We've apply the same logic for mgmt plane to data plane in Azure/autorest.csharp#2878 For backward compatiblity, we use `suppress-abstract-base-class` directive to keep the existing behavior for officially released data plane SDKs.
archerzz
requested review from
JoshLove-msft,
Kishp01,
ShivangiReja,
ahamad-MS,
annelo-msft,
giakas,
heaths,
jfggdl,
joseharriaga,
jsquire,
kinelski,
pallavit,
rasidhan,
tg-msft,
wonner and
yeskarthik
as code owners
ghost
added
6 tasks
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. Azure.IoT.TimeSeriesInsights |
heaths
approved these changes
Nov 29, 2022
Member
heaths
left a comment
heaths
left a comment
There was a problem hiding this comment.
Text Analytics and Video Analyzer LGTM
Dataflow is used in test caess, though it should be a base type (e.g. abstract)
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-net
that referenced
this pull request
Dec 7, 2022
- bump latest `autorest.csharp` and re-gen some SDKs, making base class abstract - add `suppress-abstract-base-class` for SDKs which are already released, or test case will be broken due to making base class abstract
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, dataplane does not default to abstract for base classes of polymorphic sets. We'll apply the same logic for mgmt plane to data plane in Azure/autorest.csharp#2878
For backward compatibility, we use
suppress-abstract-base-classdirective to keep the existing behavior for officially released data plane SDKs.Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.