Skip to content

Fix instance metadata validation error #32520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 2, 2022
Merged

Fix instance metadata validation error #32520

merged 10 commits into from
Dec 2, 2022

Conversation

@christothes
Copy link
Member

@christothes christothes commented Nov 16, 2022

fixes #32498

@christothes christothes self-assigned this Nov 16, 2022
@ghost ghost added the Azure.Identity label Nov 16, 2022
scottaddie
scottaddie reviewed Nov 16, 2022
View reviewed changes
christothes and others added 4 commits November 16, 2022 17:20
@christothes
cleanup
3c16bc7
@christothes
more cleanup
8a5b8bb
@christothes @scottaddie
Update sdk/identity/Azure.Identity/CHANGELOG.md
994646d 
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
@christothes
changelog tweak
7b1bd4f
@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 17, 2022

API change check

API changes are not detected in this pull request.

@amirschw
Copy link

amirschw commented Nov 24, 2022

Thanks for fixing this, @christothes! Any idea when there's going to be a new release that includes this fix? We're waiting for it to unblock our migration from AppAuthentication to Azure.Identity (we can't use the latest version because of this issue nor can we use previous versions since they don't have internal token caching for ManagedIdentityCredential).

@christothes
Copy link
Member Author

christothes commented Dec 1, 2022

Thanks for fixing this, @christothes! Any idea when there's going to be a new release that includes this fix? We're waiting for it to unblock our migration from AppAuthentication to Azure.Identity (we can't use the latest version because of this issue nor can we use previous versions since they don't have internal token caching for ManagedIdentityCredential).

Should be in January.

@christothes christothes merged commit edfcf84 into main Dec 2, 2022
@christothes christothes deleted the chriss/TokenProviderCallback-validation branch December 2, 2022 17:52
sofiar-msft pushed a commit to sofiar-msft/azure-sdk-for-net that referenced this pull request Dec 7, 2022
@christothes @sofiar-msft
Fix instance metadata validation error (Azure#32520)
7f2c43d 
* Fix instance metadata validation error
schaabs pushed a commit to schaabs/azure-sdk-for-net that referenced this pull request Jan 13, 2023
@christothes @schaabs
Fix instance metadata validation error (Azure#32520)
b03d9d9 
* Fix instance metadata validation error
schaabs added a commit that referenced this pull request Jan 13, 2023
@schaabs @christothes
Cherry-Pick Managed Identity Metadata fix for patch release 1.8.1 (#3…
3a2a7d4 
…3478)

* Fix instance metadata validation error (#32520)

* Fix instance metadata validation error

* update changelog

* feedback and fixes

Co-authored-by: Christopher Scott <chriss@microsoft.com>
@snakefoot
Copy link

snakefoot commented Jan 16, 2023

Seems #32498 has not been fixed completely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scottaddie scottaddie scottaddie left review comments

@ShivangiReja ShivangiReja Awaiting requested review from ShivangiReja

+1 more reviewer

@schaabs schaabs schaabs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@christothes christothes

Labels

Azure.Identity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Azure.Identity Question

7 participants

@christothes @azure-sdk @amirschw @snakefoot @scottaddie @schaabs