[PostgreSQL] SDK upgrade for PostgreSQL flexible server to version 2022-03-08-privatepreview #31641

alanenriqueo · 2022-10-07T03:10:29Z

Use tag flexibleserver-2022-03-privatepreview for PostgreSqlFlexibleServers.
Added FastCreate custom function for fast provisioning feature.

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

...ql/Azure.ResourceManager.PostgreSql/src/PostgreSqlFlexibleServers/Custom/FastProvisioning.cs

sdk/postgresql/Azure.ResourceManager.PostgreSql/tests/Scenario/PostgreSqlFlexibleServerTests.cs

DaeunYim · 2022-10-07T21:41:39Z

...ql/Azure.ResourceManager.PostgreSql/src/PostgreSqlFlexibleServers/Custom/FastProvisioning.cs

+        /// <param name="waitUntil"> <see cref="WaitUntil.Completed"/> if the method should wait to return until the long-running operation has completed on the service; <see cref="WaitUntil.Started"/> if it should return after starting the operation. For more information on long-running operations, please see <see href="https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/core/Azure.Core/samples/LongRunningOperations.md"> Azure.Core Long-Running Operation samples</see>. </param>
+        /// <param name="data"> The required parameters for creating a server. </param>
+        /// <param name="cancellationToken"> The cancellation token to use. </param>
+        public virtual ArmOperation<PostgreSqlFlexibleServerResource> FastProvision(WaitUntil waitUntil, PostgreSqlFlexibleServerData data, CancellationToken cancellationToken = default)


What will be the example of using this method like? Can we possibly add a sample of this in the sample repo if possible?

Sure, after this gets merged, I'll add a sample.

...stgresql/Azure.ResourceManager.PostgreSql/src/PostgreSqlFlexibleServers/Custom/FastCreate.cs

ArcturusZhang · 2022-10-12T03:03:56Z

...esql/Azure.ResourceManager.PostgreSql/api/Azure.ResourceManager.PostgreSql.netstandard2.0.cs

@@ -426,6 +426,8 @@ public static partial class FlexibleServersExtensions
    {
        public static Azure.Response<Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerNameAvailabilityResult> CheckPostgreSqlFlexibleServerNameAvailability(this Azure.ResourceManager.Resources.SubscriptionResource subscriptionResource, Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerNameAvailabilityContent content, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
        public static System.Threading.Tasks.Task<Azure.Response<Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerNameAvailabilityResult>> CheckPostgreSqlFlexibleServerNameAvailabilityAsync(this Azure.ResourceManager.Resources.SubscriptionResource subscriptionResource, Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerNameAvailabilityContent content, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
+        public static Azure.Response<Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerCachedServerName> ExecuteGetCachedServerName(this Azure.ResourceManager.Resources.ResourceGroupResource resourceGroupResource, Azure.Core.AzureLocation locationName, Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerCachedServerNameContent content, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }


The word Execute looks a bit redundant, can we rename this operation to simply GetCachedServerName?

Done, I renamed it to GetPostgreSqlFlexibleServerCachedServerName to have consistency with other operations.

archerzz · 2022-10-12T03:06:42Z

...c/PostgreSqlFlexibleServers/Generated/Models/PostgreSqlFlexibleServerCapabilityProperties.cs

        /// <param name="status"> The status. </param>
-        internal PostgreSqlFlexibleServerCapabilityProperties(string zone, bool? isGeoBackupSupported, bool? isZoneRedundantHASupported, bool? isZoneRedundantHAAndGeoBackupSupported, IReadOnlyList<PostgreSqlFlexibleServerEditionCapability> supportedFlexibleServerEditions, IReadOnlyList<PostgreSqlFlexibleServerHyperscaleNodeEditionCapability> supportedHyperscaleNodeEditions, IReadOnlyList<string> supportedHAModes, string status)


This is a breaking change. I saw the new version is 1.1.0-beta1, so it is OK. But you only change the sequence of the parameter, which should be avoided.

@alanenriqueo I just realized that there is already an official release 1.0.0. So this is a breaking change which needs to be resolved.

Here are 2 options:

Add manual codes to provide backward compatibility, see compute for reference: https://github.com/Azure/azure-sdk-for-net/tree/main/sdk/compute/Microsoft.Azure.Management.Compute/src/Customizations

Or you need to bump the major version, e.g. 2.0.0

Changing order of properties is no longer a brekaing change in track 2 SDKs

...rs/Generated/Models/PostgreSqlFlexibleServerVirtualNetworkSubnetUsageResult.Serialization.cs

Yao725 · 2022-10-12T03:47:20Z

...esql/Azure.ResourceManager.PostgreSql/api/Azure.ResourceManager.PostgreSql.netstandard2.0.cs

@@ -624,6 +632,36 @@ public partial class PostgreSqlFlexibleServerResource : Azure.ResourceManager.Ar
        public virtual Azure.ResourceManager.ArmOperation<Azure.ResourceManager.PostgreSql.FlexibleServers.PostgreSqlFlexibleServerResource> Update(Azure.WaitUntil waitUntil, Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerPatch patch, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
        public virtual System.Threading.Tasks.Task<Azure.ResourceManager.ArmOperation<Azure.ResourceManager.PostgreSql.FlexibleServers.PostgreSqlFlexibleServerResource>> UpdateAsync(Azure.WaitUntil waitUntil, Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerPatch patch, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
    }
+    public partial class PostgreSqlFlexibleServerServerBackupCollection : Azure.ResourceManager.ArmCollection, System.Collections.Generic.IAsyncEnumerable<Azure.ResourceManager.PostgreSql.FlexibleServers.PostgreSqlFlexibleServerServerBackupResource>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.PostgreSql.FlexibleServers.PostgreSqlFlexibleServerServerBackupResource>, System.Collections.IEnumerable


From the SDK API perspective, this isn't a good resource name. Why do we have two consecutive word Server? Can we omit one of them?

ArthurMa1978 · 2022-10-24T05:21:51Z

sdk/postgresql/Azure.ResourceManager.PostgreSql/src/autorest.md

@@ -14,13 +14,13 @@ modelerfour:

 batch:
  - tag: package-2020-01-01
-  - tag: package-flexibleserver-2021-06
+  - tag: flexibleserver-2022-03-privatepreview


The Azure/azure-rest-api-specs#20212 was merged 20 mins ago, do you need to update the sdk accordingly？

ArthurMa1978 · 2022-10-24T05:22:24Z

sdk/postgresql/Azure.ResourceManager.PostgreSql/CHANGELOG.md

@@ -1,14 +1,11 @@
 # Release History

-## 1.1.0-beta.1 (Unreleased)
+## 1.1.0-beta.1 (2022-10-11)


Please update this to a new release day as the swagger has just been merged 20 mins ago

And please also flip the pr from draft to Ready for review

ghost · 2022-12-23T10:04:00Z

Hi @alanenriqueo. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

ghost · 2022-12-30T11:03:29Z

Hi @alanenriqueo. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

DaeunYim reviewed Oct 7, 2022

View reviewed changes

alanenriqueo marked this pull request as ready for review October 11, 2022 02:56

alanenriqueo requested review from KrzysztofCwalina, tg-msft, m-nash, fengzhou-msft, archerzz, ArcturusZhang, Yao725 and ArthurMa1978 as code owners October 11, 2022 02:56

openapi-assignment-bot bot assigned archerzz Oct 11, 2022

ArcturusZhang reviewed Oct 12, 2022

View reviewed changes

...stgresql/Azure.ResourceManager.PostgreSql/src/PostgreSqlFlexibleServers/Custom/FastCreate.cs Show resolved Hide resolved

ArcturusZhang reviewed Oct 12, 2022

View reviewed changes

archerzz reviewed Oct 12, 2022

View reviewed changes

...rs/Generated/Models/PostgreSqlFlexibleServerVirtualNetworkSubnetUsageResult.Serialization.cs Show resolved Hide resolved

Yao725 reviewed Oct 12, 2022

View reviewed changes

alanenriqueo force-pushed the fspg-flexibleserver-2022-03-privatepreview branch from 639f00c to 4ec2526 Compare October 12, 2022 04:27

alanenriqueo added 5 commits October 11, 2022 22:07

Update PostgreSQL flexible version to 2022-03-08-privatepreview

58e3242

Add fast provisioning flow

f907f44

Change FastProvisioning to FastCreate

785cbfa

Update CHANGELOG

30331b5

Fix operation names and rename mappings

42dbf73

alanenriqueo force-pushed the fspg-flexibleserver-2022-03-privatepreview branch from 4ec2526 to 42dbf73 Compare October 12, 2022 05:16

alanenriqueo marked this pull request as draft October 12, 2022 19:05

alanenriqueo marked this pull request as ready for review October 12, 2022 19:07

Simplify FastCreate method

96e7c78

alanenriqueo marked this pull request as draft October 19, 2022 21:17

ArthurMa1978 added Mgmt This issue is related to a management-plane library. PostgreSQL labels Oct 24, 2022

ArthurMa1978 reviewed Oct 24, 2022

View reviewed changes

ghost added the no-recent-activity There has been no recent activity on this issue. label Dec 23, 2022

ghost closed this Dec 30, 2022

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PostgreSQL] SDK upgrade for PostgreSQL flexible server to version 2022-03-08-privatepreview #31641

[PostgreSQL] SDK upgrade for PostgreSQL flexible server to version 2022-03-08-privatepreview #31641

alanenriqueo commented Oct 7, 2022 •

edited

Loading

DaeunYim Oct 7, 2022

alanenriqueo Oct 10, 2022

ArcturusZhang Oct 12, 2022

alanenriqueo Oct 12, 2022 •

edited

Loading

archerzz Oct 12, 2022

archerzz Oct 13, 2022

ArcturusZhang Oct 13, 2022

Yao725 Oct 12, 2022

alanenriqueo Oct 12, 2022

ArthurMa1978 Oct 24, 2022

ArthurMa1978 Oct 24, 2022

ArthurMa1978 Oct 24, 2022

ghost commented Dec 23, 2022

ghost commented Dec 30, 2022

		/// <param name="status"> The status. </param>
		internal PostgreSqlFlexibleServerCapabilityProperties(string zone, bool? isGeoBackupSupported, bool? isZoneRedundantHASupported, bool? isZoneRedundantHAAndGeoBackupSupported, IReadOnlyList<PostgreSqlFlexibleServerEditionCapability> supportedFlexibleServerEditions, IReadOnlyList<PostgreSqlFlexibleServerHyperscaleNodeEditionCapability> supportedHyperscaleNodeEditions, IReadOnlyList<string> supportedHAModes, string status)

[PostgreSQL] SDK upgrade for PostgreSQL flexible server to version 2022-03-08-privatepreview #31641

[PostgreSQL] SDK upgrade for PostgreSQL flexible server to version 2022-03-08-privatepreview #31641

Conversation

alanenriqueo commented Oct 7, 2022 • edited Loading

Contributing to the Azure SDK

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alanenriqueo Oct 12, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Dec 23, 2022

ghost commented Dec 30, 2022

alanenriqueo commented Oct 7, 2022 •

edited

Loading

alanenriqueo Oct 12, 2022 •

edited

Loading