-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AzureMonitorExporter] minor test improvements. add additional logging to TelemetryItems
tests
#31557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API change check API changes are not detected in this pull request. |
TimothyMothra
changed the title
[AzureMonitorExporter] investigating test failures
[AzureMonitorExporter] add additional logging to Sep 30, 2022
TelemetryItems
tests
TimothyMothra
requested review from
cijothomas,
reyang,
rajkumar-rangaraj and
vishweshbankwar
as code owners
September 30, 2022 17:42
rajkumar-rangaraj
approved these changes
Sep 30, 2022
Captured the failure.
|
TimothyMothra
changed the title
[AzureMonitorExporter] add additional logging to
[AzureMonitorExporter] minor improvements. add additional logging to Sep 30, 2022
TelemetryItems
testsTelemetryItems
tests
TimothyMothra
changed the title
[AzureMonitorExporter] minor improvements. add additional logging to
[AzureMonitorExporter] minor test improvements. add additional logging to Sep 30, 2022
TelemetryItems
testsTelemetryItems
tests
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-net
that referenced
this pull request
Dec 7, 2022
…g to `TelemetryItems` tests (Azure#31557) * investigating test failures * additional logs * fix * add spanId missing from Trace tests * change LogExporterForTest to use SimpleLogRecordExportProcessor * mitigate test by using .First()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional console logging to help inspect
TelemetryItems
Still having some intermediate test failures.
I need this additional logging to identify the origin of the extra Activity TelemetryItems that are being captured by our test.
Changes
TelemetryItemOutputHelper
from "Integration.Tests" project to "CommonTestFramework"This makes this class available to all tests.
.First()
instead of.Single()
.This should prevent the random error from blocking someone else in the Azure repo.
I'll continue investigating this on a new branch.
Visual Studio Screenshot