Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ServiceBus] Cleanup references to EntityNameHelper #31553

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

danielmarbach
Copy link
Contributor

EntityNameHelper is in the Microsoft.Azure.ServiceBus package and should not be mentioned as a solution on the public XML doc since you can simply use the Subqueue type on the options.

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@ghost ghost added Service Bus customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Sep 30, 2022
@ghost
Copy link

ghost commented Sep 30, 2022

Thank you for your contribution @danielmarbach! We will review the pull request and get back to you soon.

@ghost ghost added the Community Contribution Community members are working on the issue label Sep 30, 2022
Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @danielmarbach! LGTM. I'll defer to @JoshLove-msft for final approval.

@JoshLove-msft JoshLove-msft merged commit bacc224 into Azure:main Oct 3, 2022
sofiar-msft pushed a commit to sofiar-msft/azure-sdk-for-net that referenced this pull request Dec 7, 2022
@danielmarbach danielmarbach deleted the remove-name-helper branch May 12, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Service Bus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants