Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AzureMonitorExporter] improve TelemetryItem tests #31532

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Conversation

TimothyMothra
Copy link
Contributor

TelemetryItemValidation tests are having intermittent failures.
It appears that the tests are collecting extra TelemetryItems.

Changes

  • remove static vars (ActivitySource, Meter).
  • use a unique guid per test for every string name (ActivitySourceName, MeterName, LogCategory).

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@TimothyMothra TimothyMothra enabled auto-merge (squash) September 29, 2022 21:59
@TimothyMothra TimothyMothra merged commit 1278994 into main Sep 29, 2022
@TimothyMothra TimothyMothra deleted the tilee/new_tests2 branch September 29, 2022 22:43
sofiar-msft pushed a commit to sofiar-msft/azure-sdk-for-net that referenced this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants