Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AzureMonitorExporter] cleanup Changelog before release #31359

Merged
merged 18 commits into from
Sep 28, 2022

Conversation

TimothyMothra
Copy link
Contributor

@TimothyMothra TimothyMothra commented Sep 22, 2022

Reviewing the Changelog before our next release.
I'm opening this PR so our team can discuss changes.

We already verified we have the correct sections:

  • Features Added
  • Breaking Changes
  • Bugs Fixed
  • Other Changes

TODO

@TimothyMothra
Copy link
Contributor Author

Azure SDK standards DOES specify how PR links should be formatted.

- Issue where AccountName on BlobUriBuilder would not be populated
  for non-IP style Uris ([#8638](https://github.com/Azure/azure-sdk-for-net/issues/8638))

I'll work on this change

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@TimothyMothra
Copy link
Contributor Author

I saw a planning email from Matt earlier today. Confirmed that the target release date is Friday Oct 7th.

TimothyMothra and others added 9 commits September 26, 2022 14:22
Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>
Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>
Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>
Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>
Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>
Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>
Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>
Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>
Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>
Copy link
Contributor

@vishweshbankwar vishweshbankwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - it looks clean and easy to understand now.

Copy link
Contributor

@rajkumar-rangaraj rajkumar-rangaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@TimothyMothra TimothyMothra enabled auto-merge (squash) September 28, 2022 18:58
@TimothyMothra TimothyMothra merged commit b4479a5 into main Sep 28, 2022
@TimothyMothra TimothyMothra deleted the TimothyMothra-patch-1 branch September 28, 2022 19:11
sofiar-msft pushed a commit to sofiar-msft/azure-sdk-for-net that referenced this pull request Dec 7, 2022
* [AzureMonitorExporter] cleanup Changelog before release

* update links

* Update sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/CHANGELOG.md

Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>

* Update sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/CHANGELOG.md

Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>

* Update sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/CHANGELOG.md

Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>

* Update sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/CHANGELOG.md

Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>

* Update sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/CHANGELOG.md

Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>

* Update sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/CHANGELOG.md

Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>

* Update sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/CHANGELOG.md

Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>

* Update sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/CHANGELOG.md

Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>

* Update sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/CHANGELOG.md

Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>

* Update sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/CHANGELOG.md

Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>

* reference latest OTel dependencies PR

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

* added link to ApplicationInsightsSampler

Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monitor - Exporter Monitor OpenTelemetry Exporter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants