Make AmqpMessageId and AmqpAddress a readonly struct #31345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmarbach
requested review from
JoshLove-msft,
christothes,
annelo-msft and
KrzysztofCwalina
as code owners
ghost
added
Azure.Core
customer-reported
|
Thank you for your contribution @danielmarbach! We will review the pull request and get back to you soon. |
ghost
added
the
Community Contribution
jsquire
approved these changes
Sep 22, 2022
There was a problem hiding this comment.
LGTM, but I'd like @JoshLove-msft to offer thoughts, just in case there's some scenario that I'm not thinking of.
|
Looks like CI is failing on Analyze due to needing to export the API. |
|
Will fix the API export. Sorry that is something I never remember to run :( |
danielmarbach
changed the title
You're not alone there. 😄 |
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-net
that referenced
this pull request
Dec 7, 2022
* Make AmqpMessageId a readonly struct * Make AmqpAddress a readonly struct * Approve API changes * Change log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.