Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AzureMonitorExporter] storage updates #31073

Merged
merged 5 commits into from
Sep 12, 2022
Merged

[AzureMonitorExporter] storage updates #31073

merged 5 commits into from
Sep 12, 2022

Conversation

TimothyMothra
Copy link
Contributor

@TimothyMothra TimothyMothra commented Sep 12, 2022 •
edited
Loading

Changes

  • refactor StorageHelper.
    • Removed multiple nested if statements
    • Changed CreateTelemetryDirectory method to TryCreateTelemetryDirectory
    • Simplified IsWindowsOS method
  • changed directory name to "Microsoft\AzureMonitor` according to spec.
  • updated Changelog since this is technically a breaking change

@TimothyMothra TimothyMothra added the Monitor - Exporter Monitor OpenTelemetry Exporter label Sep 12, 2022
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@TimothyMothra TimothyMothra enabled auto-merge (squash) September 12, 2022 22:20
@TimothyMothra TimothyMothra merged commit ce53856 into main Sep 12, 2022
@TimothyMothra TimothyMothra deleted the tilee/storage branch September 12, 2022 22:32
sofiar-msft pushed a commit to sofiar-msft/azure-sdk-for-net that referenced this pull request Dec 7, 2022
@TimothyMothra @sofiar-msft
[AzureMonitorExporter] storage updates (Azure#31073)
9baed87 
* update changelog

* refactor StorageHelper and change directory name

* update changelog with link to PR

* update changelog message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang left review comments

@vishweshbankwar vishweshbankwar vishweshbankwar approved these changes

@rajkumar-rangaraj rajkumar-rangaraj rajkumar-rangaraj approved these changes

@cijothomas cijothomas Awaiting requested review from cijothomas

Assignees
No one assigned
Labels
Monitor - Exporter Monitor OpenTelemetry Exporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TimothyMothra @azure-sdk @rajkumar-rangaraj @reyang @vishweshbankwar