Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix head formatting in README.md #3107

Merged
merged 5 commits into from
Apr 21, 2017
Merged

Fix head formatting in README.md #3107

merged 5 commits into from
Apr 21, 2017

Conversation

markcowl
Copy link
Member

@markcowl markcowl commented Apr 19, 2017

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as a link to the swagger spec, used to generate the code.
  • The project.json and AssemblyInfo.cs files have been updated with the new version of the SDK.

@markcowl
Copy link
Member Author

@azuresdkci retest this please

@markcowl
Copy link
Member Author

@shahabhijeet it looks like the build is failing because the CredScan exceptions are pointing at the old directory structure, can you take a look?

@shahabhijeet shahabhijeet merged commit cd16371 into vs17Dev Apr 21, 2017
@shahabhijeet shahabhijeet deleted the fix-readme-17 branch May 4, 2017 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants