Feature/storage/sas client derived #30147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Share, Datalake, and Queue Storage Client to Client tests; moved SAS test helpers to shared tests folder
ghost
added
the
|
TODO: reduce unnecessary tests that are redundant DONE |
|
API change check API changes are not detected in this pull request. |
amnguye
requested review from
seanmcc-msft,
jaschrep-msft and
tg-msft
as code owners
sdk/storage/Azure.Storage.Files.DataLake/tests/DataLakeTestBase.cs
Outdated
Show resolved
Hide resolved
|
TODO: remove permissions test, because I overlooked that we publicly allow setting the raw string permissions. (but do not remove the GetChildClient or GetParentClient tests) DONE |
jaschrep-msft
approved these changes
Aug 11, 2022
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-net
that referenced
this pull request
Dec 7, 2022
* WIP - Moved Account SAS test to separate SAS tests; Added Get File Share, Datalake, and Queue Storage Client to Client tests; moved SAS test helpers to shared tests folder * Add Account SAS blob tests * Updated Common change log and reverted back recording test settings * Remove redundant tests, added tests for GetBlobBatchClient * PR Comments; Removed unnecessary raw permissions tests; Added missing blockblob tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #29742
Also there was a bug in ShareClient and DataLakeFileSystemClient's API GetParentServiceClient would return an service client with a URL that persisted the container name. I resolved those as well and updated the changelogs.