Search SDK: Bug fixes and JSON blob parsing support #3012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alizing Also added a bunch of test coverage around boundary values.
Search SDK: Fix bug that prevented infinite double values from deserializing
Search SDK: Enable JSON blob indexer and bump version
[Search] Update analyze api tests
The Name properties of Tokenizer, TokenFilter, and CharFilter didn't have descriptions in the Swagger spec. Now that we've added them, the corresponding generated C# properties now have comments.
Search SDK: Merge AutoRest changes and add missing descriptions
shahabhijeet
added a commit
that referenced
this pull request
Apr 7, 2017
* Support for version 2017-03-01 of Azure Traffic Manager REST API. Geographic profiles * Update test recordings for version 2017-03-01 * Update generated.cmd * Update generate.cmd with the exact commit in the spec repository for Traffic Manager 2017-03-01 * Virtual Network Gateway Connection tests for Ipsec Policy Added virtual network gateway connection tests for ipsec policies Added VirtualNetworkGatewayConnection Ipsec Policies Test record Test Cases updated to use field names Connection Ipsec Policies Test session data Ipsec policies Test added for virtual network gateway connections * Generated code for network new 2017-03-01 api-version (only Ipsec Policies added compared to previous swagger) * package version incremented * Adding E2E test for VM Put bug for protected members * [ACR] Update to 2017-03-01 version 1. Update getCredentials to listCredentials to support multiple login credentials. 2. Refine regenerateCredential to support regenerate the specified login credential. 3. Add Sku to registry properties as a required property. 4. Rename GetProperties to Get. 5. Change CreateOrUpdate to Create, add registry create parameters. * Addressing PR feedback, re-recording test after addressing feedback * Update swagger link * Capabilities and security policy features. Also renamed several types and operations for improved clarify and consistency. Additions: - BlobAuditingPolicy APIs (e.g. Databases.CreateOrUpdateBlobAuditingPolicy) - ThreatDetectionPolicy APIs (e.g. Databases.CreateOrUpdateThreatDetectionPolicy) - Databases.ListByServer now supports $expand parameter - Capabilities APIs (e.g. Capabilities.ListByLocation) Types renamed: - ServerFirewallRule -> FirewallRule - DatabaseEditions -> DatabaseEdition - ElasticPoolEditions -> ElasticPoolEdition - ImportRequestParameters -> ImportRequest - ExportRequestParameters -> ExportRequest - ImportExportOperationResponse -> ImportExportResponse - OperationMode -> ImportOperationMode - TransparentDataEncryptionStates -> TransparentDataEncryptionStatus Types removed: - Unused types: UpgradeHint, Schema, Table, Column Operations renamed: - Servers.GetByResourceGroup -> Servers.Get - Servers.CreateOrUpdateFirewallRule -> FirewallRule.CreateOrUpdate, and similar for Get, List, and Delete - Databases.Import -> Databases.CreateImportOperation - Servers.Import -> Databases.Import - Databases.PauseDataWarehouse -> Databases.Pause - Databases.ResumeDataWarehouse -> Databases.Resume Operations removed: - Removed ImportExport operation results APIs since these are handled automatically by Azure async pattern. * Add preview label * #WAF added autogenerated files * #WAF changed version in rest API calls of Network/SessionRecords. * #WAF changed version in rest API calls of Compute/SessionRecords. * #WAF set x-ms-flatten to true for ApplicationGatewayFirewallRuleSet. * Revert AssemblyVersion to 2.1.0 because there are no breaking changes in this version * Revert AssemblyVersion to 2.0.0 because there are no breaking changes in this version * Added license header * Removed UpgradeLog.htm * Restore copyright header to generated files * Using proper rest api spec for 2017-03-01 generation * #WAF Added web application firewall related tests and rerecorded agw tests. * #WAF removed unneccessary file ending changes created by the PS script for updating the api version number in SessionRecords. * #WAF updated comment for ApplicationGatewayFirewallDisabledRuleGroup.rules. * #WAF incremented assembly version. * Update Network test versions to 2017-03-01 * Update releasenotes to clarify breaking changes * corrected Assembly version for 2017-03-01 * #WAF removed redundancy in description of enums. * Fix Batch management plane releasenotes reference * #WAF updated required fields for getBackendHealth Api result. * #INIT updated the api-version to 2016-03-01 in the Network *Operation.cs files. * #INIT Updated Version number to 10.0.0 (next major version) since there will be breaking changes for application gateway. * #INIT Changed version number to 2017-03-01 in Network/SessionRecordings. * #INIT Changed version number to 2017-03-01 in Compute/SessionRecordings. * #INIT Removed unneccessary changes where only end of file chagned. * AssemblyInfo revert AssemblyVersion to original as requested * #WAF Renamed GetAvailableWafRuleSets to ListAvailableWafRuleSets. * removed EOF-only changes * Reverted global.json changes * #12345: Updating generated files after fixing virtualNetworkGateway resource swagger to remove unnecessary required params. * #WAF improved tests. * Updated RepoTask module with new supported KeyValue pairs (#2919) * Updated RepoTask module with new supported KeyVaule pairs * Updating properties of the manifest file * Generate XML documentation for all libraries. (#2959) * Turn XML generation on for all projects. * Exclude Batch due to lack of proper XML comments. * #WAF Recorded new ApplicationGateway tests. * Swagger and test update for ADL (#2995) * Swagger and test update for ADL This also uses the latest nightly AutoRest generator, which results in a touch of every file. * missed recording one test. * Update version of the ADL packages before PR merge * Update changelog for the current version. * Relay SDK Draft (#2998) * Adding Relay SDK Draft * Swagger Updates. * Method name corrected * Add ServiceFabric SDK (#2903) * Add ServiceFabric SDK * update with latest swagger file * update sdk with latest Swagger * update test case * update with latest swagger file * fix build warning * fix swagger file path * Search SDK: Bug fixes and JSON blob parsing support (#3012) * Search SDK: Fix bug that prevented infinite double values from deserializing Also added a bunch of test coverage around boundary values. * Search SDK: Adding convenience method for enabling JSON blob indexers * Search SDK: Bumping version to 3.0.3 and changing release notes * Updating Analyze API tests to include MS language tokenizers * Forgot about one case * Search SDK: Adding missing descriptions The Name properties of Tokenizer, TokenFilter, and CharFilter didn't have descriptions in the Swagger spec. Now that we've added them, the corresponding generated C# properties now have comments. * Key Vault soft-delete preview (#3021) * KeyVault: Add soft delete capability to C# SDK. - Includes session recording changes. * KeyVault: Add restore, backup, recover, purge perm. * KeyVault: Increase management SDK version. - 2.0.2 for official release of management SDK. * KeyVault: Add optin soft delete flag to key vaults. * Vault-level soft-delete support. * key vault package upgrade * adding purge disabled property for key and vault purge * Regenerate the SDK based on version 1.0.0 * Azure Machine Learning WebServicesRP new API version (#3036) * Initial change for a new version * Update the POST operation id * POST method update * Make the POST call long running operation and handle the request id. * Update existing test cases to work with new API version. * Add new test case for POST * Add test case for large payload scenario. * Description update according to swagger update * Update generate.cmd to point to new swagger spec * Suppress CredScan message for certificate thumbprint, which is for encryption, not auth. * Replace real thumbprints with dummy strings * More thumbprints replaced with dummy strings * Replace hardcoded web service keys with dummy strings * Replace keys and thumbprints with dummy strings * Remove all encrypted content which were treated as credentials by CredScan in the lab build. * Update .net SDK with the latest swagger. * exporting secret backup/restore in KV .net SDK (#3035) * exposing additional signing and encryption algorithms in the KeyVault .net SDK (#3040) * exporting secret backup/restore in KV .net SDK * Azure Machine Learning WebServicesRP new API version (#3036) * Initial change for a new version * Update the POST operation id * POST method update * Make the POST call long running operation and handle the request id. * Update existing test cases to work with new API version. * Add new test case for POST * Add test case for large payload scenario. * Description update according to swagger update * Update generate.cmd to point to new swagger spec * Suppress CredScan message for certificate thumbprint, which is for encryption, not auth. * Replace real thumbprints with dummy strings * More thumbprints replaced with dummy strings * Replace hardcoded web service keys with dummy strings * Replace keys and thumbprints with dummy strings * Remove all encrypted content which were treated as credentials by CredScan in the lab build. * Update .net SDK with the latest swagger. * exposing additional signing and encryption algorithms in the KeyVault .Net SDK
shahabhijeet
added a commit
that referenced
this pull request
Apr 8, 2017
* Support for version 2017-03-01 of Azure Traffic Manager REST API. Geographic profiles * Update test recordings for version 2017-03-01 * Update generated.cmd * Update generate.cmd with the exact commit in the spec repository for Traffic Manager 2017-03-01 * Virtual Network Gateway Connection tests for Ipsec Policy Added virtual network gateway connection tests for ipsec policies Added VirtualNetworkGatewayConnection Ipsec Policies Test record Test Cases updated to use field names Connection Ipsec Policies Test session data Ipsec policies Test added for virtual network gateway connections * Generated code for network new 2017-03-01 api-version (only Ipsec Policies added compared to previous swagger) * package version incremented * Adding E2E test for VM Put bug for protected members * [ACR] Update to 2017-03-01 version 1. Update getCredentials to listCredentials to support multiple login credentials. 2. Refine regenerateCredential to support regenerate the specified login credential. 3. Add Sku to registry properties as a required property. 4. Rename GetProperties to Get. 5. Change CreateOrUpdate to Create, add registry create parameters. * Addressing PR feedback, re-recording test after addressing feedback * Update swagger link * Capabilities and security policy features. Also renamed several types and operations for improved clarify and consistency. Additions: - BlobAuditingPolicy APIs (e.g. Databases.CreateOrUpdateBlobAuditingPolicy) - ThreatDetectionPolicy APIs (e.g. Databases.CreateOrUpdateThreatDetectionPolicy) - Databases.ListByServer now supports $expand parameter - Capabilities APIs (e.g. Capabilities.ListByLocation) Types renamed: - ServerFirewallRule -> FirewallRule - DatabaseEditions -> DatabaseEdition - ElasticPoolEditions -> ElasticPoolEdition - ImportRequestParameters -> ImportRequest - ExportRequestParameters -> ExportRequest - ImportExportOperationResponse -> ImportExportResponse - OperationMode -> ImportOperationMode - TransparentDataEncryptionStates -> TransparentDataEncryptionStatus Types removed: - Unused types: UpgradeHint, Schema, Table, Column Operations renamed: - Servers.GetByResourceGroup -> Servers.Get - Servers.CreateOrUpdateFirewallRule -> FirewallRule.CreateOrUpdate, and similar for Get, List, and Delete - Databases.Import -> Databases.CreateImportOperation - Servers.Import -> Databases.Import - Databases.PauseDataWarehouse -> Databases.Pause - Databases.ResumeDataWarehouse -> Databases.Resume Operations removed: - Removed ImportExport operation results APIs since these are handled automatically by Azure async pattern. * Add preview label * #WAF added autogenerated files * #WAF changed version in rest API calls of Network/SessionRecords. * #WAF changed version in rest API calls of Compute/SessionRecords. * #WAF set x-ms-flatten to true for ApplicationGatewayFirewallRuleSet. * Revert AssemblyVersion to 2.1.0 because there are no breaking changes in this version * Revert AssemblyVersion to 2.0.0 because there are no breaking changes in this version * Added license header * Removed UpgradeLog.htm * Restore copyright header to generated files * Using proper rest api spec for 2017-03-01 generation * #WAF Added web application firewall related tests and rerecorded agw tests. * #WAF removed unneccessary file ending changes created by the PS script for updating the api version number in SessionRecords. * #WAF updated comment for ApplicationGatewayFirewallDisabledRuleGroup.rules. * #WAF incremented assembly version. * Update Network test versions to 2017-03-01 * Update releasenotes to clarify breaking changes * corrected Assembly version for 2017-03-01 * #WAF removed redundancy in description of enums. * Fix Batch management plane releasenotes reference * #WAF updated required fields for getBackendHealth Api result. * #INIT updated the api-version to 2016-03-01 in the Network *Operation.cs files. * #INIT Updated Version number to 10.0.0 (next major version) since there will be breaking changes for application gateway. * #INIT Changed version number to 2017-03-01 in Network/SessionRecordings. * #INIT Changed version number to 2017-03-01 in Compute/SessionRecordings. * #INIT Removed unneccessary changes where only end of file chagned. * AssemblyInfo revert AssemblyVersion to original as requested * #WAF Renamed GetAvailableWafRuleSets to ListAvailableWafRuleSets. * removed EOF-only changes * Reverted global.json changes * #12345: Updating generated files after fixing virtualNetworkGateway resource swagger to remove unnecessary required params. * #WAF improved tests. * Updated RepoTask module with new supported KeyValue pairs (#2919) * Updated RepoTask module with new supported KeyVaule pairs * Updating properties of the manifest file * Generate XML documentation for all libraries. (#2959) * Turn XML generation on for all projects. * Exclude Batch due to lack of proper XML comments. * #WAF Recorded new ApplicationGateway tests. * Swagger and test update for ADL (#2995) * Swagger and test update for ADL This also uses the latest nightly AutoRest generator, which results in a touch of every file. * missed recording one test. * Update version of the ADL packages before PR merge * Update changelog for the current version. * Relay SDK Draft (#2998) * Adding Relay SDK Draft * Swagger Updates. * Method name corrected * Add ServiceFabric SDK (#2903) * Add ServiceFabric SDK * update with latest swagger file * update sdk with latest Swagger * update test case * update with latest swagger file * fix build warning * fix swagger file path * Search SDK: Bug fixes and JSON blob parsing support (#3012) * Search SDK: Fix bug that prevented infinite double values from deserializing Also added a bunch of test coverage around boundary values. * Search SDK: Adding convenience method for enabling JSON blob indexers * Search SDK: Bumping version to 3.0.3 and changing release notes * Updating Analyze API tests to include MS language tokenizers * Forgot about one case * Search SDK: Adding missing descriptions The Name properties of Tokenizer, TokenFilter, and CharFilter didn't have descriptions in the Swagger spec. Now that we've added them, the corresponding generated C# properties now have comments. * Key Vault soft-delete preview (#3021) * KeyVault: Add soft delete capability to C# SDK. - Includes session recording changes. * KeyVault: Add restore, backup, recover, purge perm. * KeyVault: Increase management SDK version. - 2.0.2 for official release of management SDK. * KeyVault: Add optin soft delete flag to key vaults. * Vault-level soft-delete support. * key vault package upgrade * adding purge disabled property for key and vault purge * Regenerate the SDK based on version 1.0.0 * Azure Machine Learning WebServicesRP new API version (#3036) * Initial change for a new version * Update the POST operation id * POST method update * Make the POST call long running operation and handle the request id. * Update existing test cases to work with new API version. * Add new test case for POST * Add test case for large payload scenario. * Description update according to swagger update * Update generate.cmd to point to new swagger spec * Suppress CredScan message for certificate thumbprint, which is for encryption, not auth. * Replace real thumbprints with dummy strings * More thumbprints replaced with dummy strings * Replace hardcoded web service keys with dummy strings * Replace keys and thumbprints with dummy strings * Remove all encrypted content which were treated as credentials by CredScan in the lab build. * Update .net SDK with the latest swagger. * exporting secret backup/restore in KV .net SDK (#3035) * exposing additional signing and encryption algorithms in the KeyVault .net SDK (#3040) * exporting secret backup/restore in KV .net SDK * Azure Machine Learning WebServicesRP new API version (#3036) * Initial change for a new version * Update the POST operation id * POST method update * Make the POST call long running operation and handle the request id. * Update existing test cases to work with new API version. * Add new test case for POST * Add test case for large payload scenario. * Description update according to swagger update * Update generate.cmd to point to new swagger spec * Suppress CredScan message for certificate thumbprint, which is for encryption, not auth. * Replace real thumbprints with dummy strings * More thumbprints replaced with dummy strings * Replace hardcoded web service keys with dummy strings * Replace keys and thumbprints with dummy strings * Remove all encrypted content which were treated as credentials by CredScan in the lab build. * Update .net SDK with the latest swagger. * exposing additional signing and encryption algorithms in the KeyVault .Net SDK * RecoveryServicess on latest Swagger (#3028) * RecoveryServicess on latest Swagger * Updated generate cmd and project json with links * Added AssemblyInfo.cs file * Added license header and additional constructor for passing http client Using the ctor without root client handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for the upcoming 3.0.3 release of the Azure Search .NET SDK. It includes support for parsing JSON blobs, as well as some bug fixes:
AnalyzeAPI with the standard Lucene analyzer and the Microsoft language and stemming tokenizers.Tokenizer,TokenFilter, andCharFilter.The corresponding Swagger spec changes are in this PR: Azure/azure-rest-api-specs#1086
FYI @chaosrealm @Yahnoosh @bernitorres
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
project.jsonandAssemblyInfo.csfiles have been updated with the new version of the SDK.