Update Azure.Batch to MIT license. #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also updated readme.md and changelog.md in preparation for this to be released. - Includes update to the nuget package license as well.
|
@hovsepm - Here you go @darylmsft @itowlson @xingwu1 - please review. Specifically I would call out the project.json, Readme.md, and changelog.md as good candidates for review. The other files were bulk find-replaced so you probably don't need to review them all. Before mergingPlease wait until some folks from my team review this and sign off |
itowlson
reviewed
Mar 13, 2017
| @@ -1,3 +1,6 @@ | |||
| # License notes | |||
| The Azure Batch C# client is now under the MIT license. Prior to 3/10/2017 it was under the Apache 2.0 license. | |||
There was a problem hiding this comment.
Prefer to spell out dates - many readers will be in dd/mm/yyyy locales.
| These changes are planned but haven't been published yet. | ||
|
|
||
| #### License | ||
| Moved source code and NuGet package from Apache 2.0 license to MIT license. This is more consistent with the other Azure SDKs as well as other open source projects from Microsoft such as DotNet. |
There was a problem hiding this comment.
"DotNet" is not normally spelled out that way. The product is ".NET". They use "dotnet" as the user name under which they keep their GitHub repos, and in other places where the leading "." isn't allowed... but this seems to refer to the product...?
openapi-sdkautomation-test bot
pushed a commit
to openapi-env-test/azure-sdk-for-net
that referenced
this pull request
Jun 15, 2021
Revert "Update readme.md (Azure#2922)" (Azure#2923) This reverts commit 6c93aed55698e5fa4c31fca6bf2af72a57de1bb6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
project.jsonandAssemblyInfo.csfiles have been updated with the new version of the SDK.