Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TA] Implementation to support FHIR #28809

Merged
merged 5 commits into from
May 17, 2022
Merged

[TA] Implementation to support FHIR #28809

merged 5 commits into from
May 17, 2022

Conversation

maririos
Copy link
Member

Fixes: #28328

@azure-sdk
Copy link
Collaborator

azure-sdk commented May 16, 2022

API change check for Azure.AI.TextAnalytics

API changes have been detected in Azure.AI.TextAnalytics. You can review API changes here

API changes

+         public FhirVersion? FhirVersion { get; set; }
+         public IReadOnlyDictionary<string, object> FhirBundle { get; }
+         [EditorBrowsable(EditorBrowsableState.Never)]
+         public static AnalyzeHealthcareEntitiesResult AnalyzeHealthcareEntitiesResult(string id, TextDocumentStatistics statistics, IEnumerable<HealthcareEntity> healthcareEntities, IEnumerable<HealthcareEntityRelation> entityRelations, IEnumerable<TextAnalyticsWarning> warnings, IDictionary<string, object> fhirBundle);

Copy link
Member

@deyaaeldeen deyaaeldeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Perhaps one nitpicky thing to consider is mention a thing or two about FHIR protocol in the changelog to educate customers about the feature.

@maririos
Copy link
Member Author

/azp run net - textanalytics - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maririos
Copy link
Member Author

/azp run net - textanalytics - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maririos
Copy link
Member Author

/azp run net - textanalytics - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maririos
Copy link
Member Author

@jsquire My last commit includes the fix for this to work in both legacy and language clients. To keep it consistent with the work you did in legacy, I decided on not touching Transforms.Legacy and instead, having another constructor that takes the new parameters. Apologies for the iterations in the PR while figuring out best approach.
Let me know what you think.

@maririos maririos requested a review from jsquire May 17, 2022 16:24
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.AI.TextAnalytics

@maririos
Copy link
Member Author

/azp run net - textanalytics - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maririos maririos merged commit 52e069d into Azure:main May 17, 2022
zhihaoxue pushed a commit to zhihaoxue/azure-sdk-for-net that referenced this pull request Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable FHIR parameter into existing Healthcare endpoint
6 participants