-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TA] Implementation to support FHIR #28809
Conversation
API change check for API changes have been detected in API changes + public FhirVersion? FhirVersion { get; set; }
+ public IReadOnlyDictionary<string, object> FhirBundle { get; }
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ public static AnalyzeHealthcareEntitiesResult AnalyzeHealthcareEntitiesResult(string id, TextDocumentStatistics statistics, IEnumerable<HealthcareEntity> healthcareEntities, IEnumerable<HealthcareEntityRelation> entityRelations, IEnumerable<TextAnalyticsWarning> warnings, IDictionary<string, object> fhirBundle); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Perhaps one nitpicky thing to consider is mention a thing or two about FHIR protocol in the changelog to educate customers about the feature.
sdk/textanalytics/Azure.AI.TextAnalytics/tests/RecognizeHealthcareEntitiesTests.cs
Show resolved
Hide resolved
sdk/textanalytics/Azure.AI.TextAnalytics/src/ServiceClients/LanguageServiceClient.cs
Show resolved
Hide resolved
sdk/textanalytics/Azure.AI.TextAnalytics/tests/RecognizeHealthcareEntitiesTests.cs
Show resolved
Hide resolved
sdk/textanalytics/Azure.AI.TextAnalytics/tests/RecognizeHealthcareEntitiesTests.cs
Show resolved
Hide resolved
sdk/textanalytics/Azure.AI.TextAnalytics/tests/RecognizeHealthcareEntitiesTests.cs
Show resolved
Hide resolved
/azp run net - textanalytics - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run net - textanalytics - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run net - textanalytics - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
@jsquire My last commit includes the fix for this to work in both legacy and language clients. To keep it consistent with the work you did in legacy, I decided on not touching |
API change check APIView has identified API level changes in this PR and created following API reviews. |
/azp run net - textanalytics - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
Fixes: #28328