-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing new Microsoft.Azure.Monitor.dll for the Monitor team (formerly Insights) #2832
Conversation
…he generate.cmd file
…into AutoRest # Conflicts: # src/ResourceManagement/Insights/Insights.Tests/project.json
The errors don't seem to be coming from our code, but from Data Lake's. |
@azuresdkci test this please |
@twitchax Please let us know how to handle this - should this be a new package, or a new version of Insights? It looks liek the namespaces in AzureRm have not changed. Needf to reach out to the PMs on the team to decide. |
Based on previous discussions with them, this should be a separate package, and the old package will no longer ship (it was in preview). |
Synced with them, and this should be a new package. |
@markcowl: discussed the deprecation of the "Insights" package and redirection to the "Monitor" package...got the go ahead. |
Description
Introducing a new folder in this repo: monitor, which contains the code generated from the new Swagger specs folders called monitor, arm-monitor (PR merged recently Azure/azure-rest-api-specs#936).
With this we are effectively introducing a new SDK dll called Microsoft.Azure.Monitor.dll intended to replace Microsoft.Azure.Insights.dll.
The contents of the dlls are almost identical with these differences:
This name change is intended to avoid confusions with AppInsights artifacts and to align with the new name of our team.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
project.json
andAssemblyInfo.cs
files have been updated with the new version of the SDK.