Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing new Microsoft.Azure.Monitor.dll for the Monitor team (formerly Insights) #2832

Merged
merged 15 commits into from
Mar 3, 2017

Conversation

gucalder
Copy link
Contributor

Description

Introducing a new folder in this repo: monitor, which contains the code generated from the new Swagger specs folders called monitor, arm-monitor (PR merged recently Azure/azure-rest-api-specs#936).

With this we are effectively introducing a new SDK dll called Microsoft.Azure.Monitor.dll intended to replace Microsoft.Azure.Insights.dll.
The contents of the dlls are almost identical with these differences:

  • Monitor.dll does not contain the old Metrics API
  • Some minor improvements derived from the process of validation of the Swagger spec.
  • One change due to the resolution of an issue with the Python CLI generation.
  • The Events operations were renamed to ActivityLogs, but their calls remain unchanged.

This name change is intended to avoid confusions with AppInsights artifacts and to align with the new name of our team.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as a link to the swagger spec, used to generate the code.
  • The project.json and AssemblyInfo.cs files have been updated with the new version of the SDK.

@gucalder
Copy link
Contributor Author

The errors don't seem to be coming from our code, but from Data Lake's.

@shahabhijeet
Copy link
Member

@azuresdkci test this please

@markcowl
Copy link
Member

@twitchax Please let us know how to handle this - should this be a new package, or a new version of Insights? It looks liek the namespaces in AzureRm have not changed. Needf to reach out to the PMs on the team to decide.

@twitchax
Copy link
Contributor

Based on previous discussions with them, this should be a separate package, and the old package will no longer ship (it was in preview).

@twitchax twitchax assigned markcowl and unassigned twitchax Feb 28, 2017
@twitchax
Copy link
Contributor

Synced with them, and this should be a new package.

@twitchax
Copy link
Contributor

twitchax commented Mar 1, 2017

@markcowl: discussed the deprecation of the "Insights" package and redirection to the "Monitor" package...got the go ahead.

@markcowl markcowl merged commit 7d293a1 into Azure:AutoRest Mar 3, 2017
@gucalder gucalder deleted the Rename branch August 23, 2017 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants