refactor(mgmt): improve resources names
#27795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `rename-rule` to replace all suffixes `Urls` with `Uris` - rename `CleanupOptions` to `ScriptCleanupOptions` - rename `StorageAccountConfiguration` to `ScriptStorageAccountConfiguration` - rename `EnvironmentVariable` to `ScriptEnvironmentVariable` - rename and change the type from `string` to `Uri` for the properties of `ArmApplicationPackageSupportUris` - `AzurePublicCloud` to `AzurePublicCloudUri` - `AzureGovernment` to `AzureGovernmentUri` - rename `JitSchedulingPolicy.Duration` to `JitSchedulingPolicy.Interval` - rename `ProvisioningOperation` to `ProvisioningOperationKind` - rename `BasicDependency` to `BasicArmDependency` - rename `ExpressionEvaluationOptionsScopeType` to `ExpressionEvaluationScope` - rename `OnErrorDeployment` to `ErrorDeployment` - rename `OnErrorDeploymentType` to `ErrorDeploymentType` - rename `OnErrorDeployment.OnErrorDeploymentType` and `OnErrorDeploymentExtended.OnErrorDeploymentType` to `ErrorDeploymentType` - rename `DeploymentPropertiesExtended.OnErrorDeployment` to `ErrorDeployment` - rename `ParametersLink` to `ArmDeploymentParametersLink` - rename `TemplateLink` to `ArmDeploymentTemplateLink` - rename `ChangeType` to `WhatIfChangeType` - rename `PropertyChangeType` to `WhatIfPropertyChangeType`
archerzz
requested review from
ArcturusZhang,
ArthurMa1978,
Yao725,
fengzhou-msft and
m-nash
as code owners
# Conflicts: # sdk/resources/Azure.ResourceManager.Resources/src/Generated/Models/AzureCliScript.cs # sdk/resources/Azure.ResourceManager.Resources/src/Generated/Models/AzurePowerShellScript.cs
Collaborator
|
API changes have been detected in |
47 tasks
ArthurMa1978
approved these changes
Mar 28, 2022
m-nash
requested changes
Mar 28, 2022
sdk/resources/Azure.ResourceManager.Resources/src/Generated/Models/ArmDeploymentProperties.cs
Outdated
Show resolved
Hide resolved
sdk/resources/Azure.ResourceManager.Resources/src/Generated/Models/ArmDeploymentProperties.cs
Outdated
Show resolved
Hide resolved
m-nash
approved these changes
Mar 28, 2022
Collaborator
|
API changes have been detected in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename-ruleto replace all suffixesUrlswithUrisCleanupOptionstoScriptCleanupOptionsStorageAccountConfigurationtoScriptStorageAccountConfigurationEnvironmentVariabletoScriptEnvironmentVariablestringtoUrifor the properties ofArmApplicationPackageSupportUrisAzurePublicCloudtoAzurePublicCloudUriAzureGovernmenttoAzureGovernmentUriJitSchedulingPolicy.DurationtoJitSchedulingPolicy.IntervalProvisioningOperationtoProvisioningOperationKindBasicDependencytoBasicArmDependencyExpressionEvaluationOptionsScopeTypetoExpressionEvaluationScopeOnErrorDeploymenttoErrorDeploymentOnErrorDeploymentTypetoErrorDeploymentTypeOnErrorDeployment.OnErrorDeploymentTypeandOnErrorDeploymentExtended.OnErrorDeploymentTypetoErrorDeploymentTypeDeploymentPropertiesExtended.OnErrorDeploymenttoErrorDeploymentParametersLinktoArmDeploymentParametersLinkTemplateLinktoArmDeploymentTemplateLinkChangeTypetoWhatIfChangeTypePropertyChangeTypetoWhatIfPropertyChangeTypeStorageAccountConfigurationtoScriptStorageConfiguration#27375