Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compute] CDRP SDK https://github.com/Azure/azure-rest-api-specs/pull/18351 #27726

Merged
merged 10 commits into from
Apr 21, 2022

Conversation

haagha
Copy link
Member

@haagha haagha commented Mar 23, 2022

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@ghost ghost added the Compute label Mar 23, 2022
@haagha haagha marked this pull request as ready for review March 29, 2022 23:02
@haagha haagha changed the title CDRP SDK [Compute] CDRP SDK https://github.com/Azure/azure-rest-api-specs/pull/18351 Mar 29, 2022
@haagha
Copy link
Member Author

haagha commented Mar 30, 2022

@m-nash can you help with the CI failure? Also this is generated from preview Swagger, should we merge it to main?

Copy link
Member

@archerzz archerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haagha
Copy link
Member Author

haagha commented Apr 19, 2022

Need to change the API tag in https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/compute/Microsoft.Azure.Management.Compute/AzSdk.RP.props

@archerzz This is supposed to be preview SDK, if I change API tag it will show in consequent stable SDK's. Is that fine?
2nd question: When I publish the SDK should I do it from main or cdrpsdk branch?

@archerzz
Copy link
Member

Need to change the API tag in https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/compute/Microsoft.Azure.Management.Compute/AzSdk.RP.props

@archerzz This is supposed to be preview SDK, if I change API tag it will show in consequent stable SDK's. Is that fine? 2nd question: When I publish the SDK should I do it from main or cdrpsdk branch?

@haagha It's OK to have preview api tag. You can see them in other SDKs as well, like this.
It's recommended to release from main. You can specify specific commit in the release job, if necessary.

@archerzz
Copy link
Member

/check-enforcer evaluate

@archerzz
Copy link
Member

/check-enforcer reset

@archerzz archerzz merged commit 4a52287 into main Apr 21, 2022
@archerzz archerzz deleted the cdrpsdk branch April 21, 2022 05:51
paterasMSFT pushed a commit that referenced this pull request Jun 15, 2022
* Initial commit.

* update version

* adding preview

* assembly version change

* fix compute_resource-manager

* fix resource_manager

* assembly changes

* tags and assembly version

* version update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants