Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mgmt): add Resource suffix #27588

Merged
merged 23 commits into from
Mar 22, 2022
Merged

feat(mgmt): add Resource suffix #27588

merged 23 commits into from
Mar 22, 2022

Conversation

archerzz
Copy link
Member

Related to Azure/autorest.csharp#2067

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@archerzz archerzz mentioned this pull request Mar 16, 2022
Merged
6 tasks
@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Sql. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Cdn. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Sql. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.AppConfiguration. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Hci. You can review API changes here

archerzz added 6 commits March 17, 2022 21:13
@archerzz
feat(mgmt): add Resource suffix
987ee4e
@archerzz
update remaining track2 SDKs
03766f5 
- appconfiguration
- azurestackhci
@archerzz
update cdn track2 mgmt sdk
92d1cf6
@archerzz
update track2 mgmt sdk
d03e415 
- communication
- compute
- connectedvmwarevshpere
- cosmosdb: disable autoscaling operation tests
- desktopvirtualiation
- deviceupdate
@archerzz
update resource manager
5121cd8
@archerzz
update based on updated resource manager
f53be68
@archerzz archerzz force-pushed the mgmt/add-resource-suffix branch from 63476cc to f53be68 Compare March 17, 2022 18:19
@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.AppConfiguration. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Resources. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.ExtendedLocation. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.CosmosDB. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.EventHubs. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.EdgeOrder. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Communication. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.ConnectedVMwarevSphere. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Hci. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Compute. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.DeviceUpdate. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.ServiceBus. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.KeyVault. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Cdn. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Network. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.StoragePool. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.WebPubSub. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.CosmosDB. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Cdn. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.StoragePool. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Dashboard. You can review API changes here

API changes

-         public static Response<GrafanaResource> GetGrafanaResource(this ResourceGroup resourceGroup, string workspaceName, CancellationToken cancellationToken = default);
+         public static Response<GrafanaResource> GetGrafanaResource(this ResourceGroupResource resourceGroupResource, string workspaceName, CancellationToken cancellationToken = default);
-         public static Task<Response<GrafanaResource>> GetGrafanaResourceAsync(this ResourceGroup resourceGroup, string workspaceName, CancellationToken cancellationToken = default);
-         public static Pageable<GrafanaResource> GetGrafanaResources(this Subscription subscription, CancellationToken cancellationToken = default);
-         public static GrafanaResourceCollection GetGrafanaResources(this ResourceGroup resourceGroup);
-         public static AsyncPageable<GrafanaResource> GetGrafanaResourcesAsync(this Subscription subscription, CancellationToken cancellationToken = default);
+         public static Task<Response<GrafanaResource>> GetGrafanaResourceAsync(this ResourceGroupResource resourceGroupResource, string workspaceName, CancellationToken cancellationToken = default);
+         public static Pageable<GrafanaResource> GetGrafanaResources(this SubscriptionResource subscriptionResource, CancellationToken cancellationToken = default);
+         public static GrafanaResourceCollection GetGrafanaResources(this ResourceGroupResource resourceGroupResource);
+         public static AsyncPageable<GrafanaResource> GetGrafanaResourcesAsync(this SubscriptionResource subscriptionResource, CancellationToken cancellationToken = default);

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.WebPubSub. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Sql. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.ConnectedVMwarevSphere. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.DesktopVirtualization. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.ExtendedLocation. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Network. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Communication. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Hci. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.DeviceUpdate. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.AppService. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.ResourceManager.Storage. You can review API changes here

@m-nash m-nash enabled auto-merge (squash) March 22, 2022 19:47
@m-nash m-nash merged commit a613ce4 into Azure:main Mar 22, 2022
@commit-lint commit-lint bot mentioned this pull request Apr 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-nash m-nash m-nash approved these changes

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina KrzysztofCwalina is a code owner

@tg-msft tg-msft Awaiting requested review from tg-msft tg-msft is a code owner

@fengzhou-msft fengzhou-msft Awaiting requested review from fengzhou-msft

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang ArcturusZhang is a code owner

@Yao725 Yao725 Awaiting requested review from Yao725

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

@chidozieononiwu chidozieononiwu Awaiting requested review from chidozieononiwu

@weshaggard weshaggard Awaiting requested review from weshaggard

@benbp benbp Awaiting requested review from benbp

@JoshLove-msft JoshLove-msft Awaiting requested review from JoshLove-msft JoshLove-msft is a code owner

@christothes christothes Awaiting requested review from christothes christothes is a code owner

@annelo-msft annelo-msft Awaiting requested review from annelo-msft annelo-msft is a code owner

@amishra-dev amishra-dev Awaiting requested review from amishra-dev

@seanmcc-msft seanmcc-msft Awaiting requested review from seanmcc-msft seanmcc-msft is a code owner

@amnguye amnguye Awaiting requested review from amnguye amnguye is a code owner

Assignees
No one assigned
Labels
Do Not Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@archerzz @azure-sdk @m-nash