Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resources][Sql] Fix tests #26432

Merged

Conversation

Yao725
Copy link
Member

@Yao725 Yao725 commented Jan 18, 2022

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
    

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@Yao725 Yao725 merged commit 25baa23 into Azure:bump_autorest_for_autogen_resourcemanager Jan 18, 2022
ArthurMa1978 added a commit that referenced this pull request Jan 19, 2022
* autogen resourceGroup

* autogen subscription and tenant

* autogen management group

* unflatten

* autogen Tag

* autogen providers, features

* autogen GenericResource

* add custom code

* customize managementgroup

* remove unused models

* consolidate location and resourceIdentifier changes

* fix tests

* replace extensions with partial classes

* regenerate

* fix tag methods

* fix waitForCompletion

* fix tests

* regenerate with api version changes

* fix tests

* suppress some warnings

* fix test mode

* regenerate

* bump autorest.csharp

* update resources autorest.md

* regenerate sdks

* fix tag operations

* [Cdn][DeviceUpdate][EventHubs][ServiceBus] Fix tests after bump autorest version (#26422)

* fix cdn

* fix deviceupdate

* fix eventhubs

* fix servicebus

* bump autorest

* fix `storage` test cases

- fix broken api invocation in tests and samples
- update test recordings

* regenerate

* fix appconfiguration and dns (#26429)

- Export-API and re-record test record for appconfiguration and dns
- fix test for appconfiguration

* [Resources][Sql] Fix tests (#26432)

* fix cdn

* fix deviceupdate

* fix eventhubs

* fix servicebus

* fix resources

* fix sql

* fix after regen

* Fix [WebPubSub] [Communication] ci error

1.update test cases
2.update sample
3.update export-api

* regenerate AppService

* Update compute (#26433)

* regenerate compute

* record test cases

* remove all the generated code to regenerate

* regenerate compute to add things back

* remove all the things

* regenerate

* fix test cases for compute

* fix spellcheck

* Fix for ML, DNS

* Update Azure.ResourceManager.WebPubSub.netstandard2.0.cs

* update autorest version to 3.0.0-beta.20220118.1

* fix `cosmosdb` test cases

- fix broken api invocation in tests and samples
- update test recordings

* update api of connectedvmwarevsphere

* update api of edgeorder, extendedlcoation, resourcemanager

* udpate apis of compute and cosmosdb

* update resourcemanager readme

* Fix app service

* fix inconsistent samples and readme in `storage`

* fix compilation error due to interface change in `storage`

* Update Azure.ResourceManager.AppService.netstandard2.0.cs

* Update the KeyVault RP which also upgrade to using new swagger 2021-10-01

Co-authored-by: Yao Kou <yaokou@microsoft.com>
Co-authored-by: archerzz <archerzz@gmail.com>
Co-authored-by: liurunliang <vghfvyyg@hotmail.com>
Co-authored-by: Chengming Ruan (WICRESOFT NORTH AMERICA LTD) <v-cruan@microsoft.com>
Co-authored-by: Dapeng Zhang <dapzhang@microsoft.com>
Co-authored-by: Minghao Chen <30464227+HarveyLink@users.noreply.github.com>
Co-authored-by: Arthur Ma <arthurma@microsoft.com>
@Yao725 Yao725 deleted the fix-tests branch January 19, 2022 09:13
ArcturusZhang added a commit that referenced this pull request Jan 21, 2022
* autogen resourceGroup

* autogen subscription and tenant

* autogen management group

* unflatten

* autogen Tag

* autogen providers, features

* autogen GenericResource

* add custom code

* customize managementgroup

* remove unused models

* consolidate location and resourceIdentifier changes

* fix tests

* replace extensions with partial classes

* regenerate

* fix tag methods

* fix waitForCompletion

* fix tests

* regenerate with api version changes

* fix tests

* suppress some warnings

* fix test mode

* regenerate

* bump autorest.csharp

* update resources autorest.md

* regenerate sdks

* fix tag operations

* [Cdn][DeviceUpdate][EventHubs][ServiceBus] Fix tests after bump autorest version (#26422)

* fix cdn

* fix deviceupdate

* fix eventhubs

* fix servicebus

* bump autorest

* fix `storage` test cases

- fix broken api invocation in tests and samples
- update test recordings

* regenerate

* fix appconfiguration and dns (#26429)

- Export-API and re-record test record for appconfiguration and dns
- fix test for appconfiguration

* [Resources][Sql] Fix tests (#26432)

* fix cdn

* fix deviceupdate

* fix eventhubs

* fix servicebus

* fix resources

* fix sql

* fix after regen

* Fix [WebPubSub] [Communication] ci error

1.update test cases
2.update sample
3.update export-api

* regenerate AppService

* Update compute (#26433)

* regenerate compute

* record test cases

* remove all the generated code to regenerate

* regenerate compute to add things back

* remove all the things

* regenerate

* fix test cases for compute

* fix spellcheck

* Fix for ML, DNS

* Update Azure.ResourceManager.WebPubSub.netstandard2.0.cs

* update autorest version to 3.0.0-beta.20220118.1

* fix `cosmosdb` test cases

- fix broken api invocation in tests and samples
- update test recordings

* update api of connectedvmwarevsphere

* update api of edgeorder, extendedlcoation, resourcemanager

* udpate apis of compute and cosmosdb

* update resourcemanager readme

* Fix app service

* fix inconsistent samples and readme in `storage`

* fix compilation error due to interface change in `storage`

* Update Azure.ResourceManager.AppService.netstandard2.0.cs

* Update the KeyVault RP which also upgrade to using new swagger 2021-10-01

* fix broken codes in `network`

1. generate latest codes
2. fix broken test cases
3. update test recordings

* fix spellcheck for keyvault

* Update keyvault code

* Update keyvault doc

* remove Azure.ResourceManager.ContainerService.sln

* temp

* correction for OS and VM

* Revert "fix spellcheck"

This reverts commit 4cb76d3.

* fix test cases and update snippet

Co-authored-by: Feng Zhou <fenzhou@microsoft.com>
Co-authored-by: Yao Kou <yaokou@microsoft.com>
Co-authored-by: archerzz <archerzz@gmail.com>
Co-authored-by: liurunliang <vghfvyyg@hotmail.com>
Co-authored-by: Chengming Ruan (WICRESOFT NORTH AMERICA LTD) <v-cruan@microsoft.com>
Co-authored-by: Minghao Chen <30464227+HarveyLink@users.noreply.github.com>
Co-authored-by: Arthur Ma <arthurma@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant