Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update autorest.md in connectedvmware #26051

Merged
merged 10 commits into from
Dec 24, 2021
Merged

update autorest.md in connectedvmware #26051

merged 10 commits into from
Dec 24, 2021

Conversation

ArcturusZhang
Copy link
Member

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@ArcturusZhang ArcturusZhang enabled auto-merge (squash) December 24, 2021 03:19
@ArcturusZhang ArcturusZhang enabled auto-merge (squash) December 24, 2021 06:16
Yao725
Yao725 reviewed Dec 24, 2021
View reviewed changes
Copy link
Member

@Yao725 Yao725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The artifact name in ci.yml should also be updated to keep package name consistency.

@ArcturusZhang ArcturusZhang merged commit ea7e9cd into Azure:main Dec 24, 2021
@ArcturusZhang ArcturusZhang deleted the connectedvmware branch December 24, 2021 06:49
HarveyLink added a commit that referenced this pull request Jan 4, 2022
@HarveyLink @dvbb
@azure-sdk @pakrym @changlong-liu @ArcturusZhang @fengzhou-msft @pratimaupadhyay02 @Yao725 @archerzz @ArthurMa1978 @johnthcall @kendaleiv @bobychaudhary @heaths @benbp
Communication release (#26150)
71ab0a3 
* fix Build error

* Update AutoRest C# version to 3.0.0-beta.20211222.1 (#26024)

* Delete unused records (#26036)

* MockTestBase: playback if no mock server (#25880)

* check-and-playback

* don't ensure in playback

* stateless-mock

* update-mock-page

* Update unit test cases

1. update TestBase.cs
2. delete ListByRGTests and CheckAvailabilityTests
3. modify CommunicationCrudTests and NotificationHubTests

* re-gen

* Update Azure.ResourceManager.Communication.netstandard2.0.cs

* sample

* Update AutoRest C# version (#26041)

* Update AutoRest C# version to 3.0.0-beta.20211222.4

* update api

* fix test cases in appconfiguration

* update compute test

* update cosmosdb test

* update keyvault test

* update snippets

* update eventhub

Co-authored-by: ArcturusZhang <dapzhang@microsoft.com>

* Release Azure.ResourceManager 1.0.0-beta.7 (#26040)

* update version to 1.0.0-beta.7

* Update CHANGELOG.md

* update readme

* re-gen

* rename

* Update Azure.ResourceManager.Communication.netstandard2.0.cs

* changlog

* SDK update for recoveryservices-backup (#26025)

* SDK update for recoveryservices-backup

* Updating

* Updating tests

* Updating assemblyInfo, csproj and azSDK.RP.props

* Update AutoRest C# version to 3.0.0-beta.20211223.1 (#26052)

* update autorest.md in connectedvmware (#26051)

* update autorest.md

* delete the directory with old casing

* regenerate everything

* fix casing

* change the casing

* remove auto generated things

* finally

* update api

* missed one casing in test project

* update sample

* drop duplicated [.cs] suffix

* Update README.md

* bump resource manager version (#26053)

* docs(network): changes for beta5 (#26054)

- add change logs
- update README.md

* docs(storage): changes for beta5 (#26055)

- add change logs
- update README.md

* Update AutoRest C# version (#26061)

* Update AutoRest C# version to 3.0.0-beta.20211224.1

* fix

Co-authored-by: ArcturusZhang <dapzhang@microsoft.com>

* Increment version for resourcemanager releases (#26050)

Increment package version after release of Azure.ResourceManager

* docs(cosmos): prepare change log for beta2 (#26066)

1. add change log for cosmos beta.2
2. fix change logs of network and storage

* [Resources][Compute][KeyVault] Update changelog and readme (#26058)

* update changelog and readme

* update changelog again

* update

* address comments

* update network and storage

* update changelog of cosmos and sql (#26067)

* update changelog of cosmos and sql

* update

* Revert the version of ResourceManager back to beta.7 to unblock release RP libs (#26074)

* Avoid always locking in BearerTokenAuthenticationPolicy (#25522)

* Ignore private setters during strongly typed deserialization (#26078)

* Spelling fix (#26075)

* prepare network and cosmos beta release (#26079)

bump release date of:
- network beta.5
- cosmos beta.2

* clean up configurations (#26070)

* prepare release for storage beta.5 (#26080)

bump release date

* Increment version for network releases (#26082)

Increment package version after release of Azure.ResourceManager.Network

* Refine the configuration of AppService (#26056)

* some update on autorest.md

* some changes

* some changes

* fix test cases

* update api

* update release date (#26088)

* Rename ConnectedVMware to ConnectedVMwarevSphere (#26090)

* Rename ConnectedVMware to ConnectedVMwarevSphere

* Update spell check

* Fixed casing problem

* Increment version for keyvault releases (#26093)

Increment package version after release of Azure.ResourceManager.KeyVault

* Increment version for resources releases (#26092)

Increment package version after release of Azure.ResourceManager.Resources

* Release Azure.ResourceManager.WebPubSub 1.0.0-beta.2 (#26091)

* Release Azure.ResourceManager.Sql 1.0.0-beta.2 (#26089)

* update release date

* Update README.md

* Increment version for compute releases (#26094)

Increment package version after release of Azure.ResourceManager.Compute

* update changelog (#26096)

* Release Azure.ResourceManager.WebPubSub 1.0.0-beta.2  (#26099)

* Release Azure.ResourceManager.WebPubSub 1.0.0-beta.2

* Update change log

* Increment version for cosmosdb releases (#26083)

Increment package version after release of Azure.ResourceManager.CosmosDB

* Increment version for deviceupdate releases (#26100)

Increment package version after release of Azure.ResourceManager.DeviceUpdate

* Increment version for storage releases (#26084)

Increment package version after release of Azure.ResourceManager.Storage

* Increment version for servicebus releases (#26101)

Increment package version after release of Azure.ResourceManager.ServiceBus

* Increment version for cdn releases (#26102)

Increment package version after release of Azure.ResourceManager.Cdn

* Increment version for webpubsub releases (#26105)

Increment package version after release of Azure.ResourceManager.WebPubSub

* Increment version for sqlmanagement releases (#26106)

Increment package version after release of Azure.ResourceManager.Sql

* Update AzureSDKCodeGeneration_DataPlane_Quickstart.md (#26108)

Minor typo mistake

* Increment package version after release of Azure.ResourceManager.EventHubs (#26103)

* docs(core): improve pipeline sample (#26095)

* Add compatibility tests for Table extension (#26038)

* Update AutoRest C# version to 3.0.0-beta.20211227.1 (#26104)

* Update AutoRest C# version to 3.0.0-beta.20211228.3 (#26112)

* Temporarily disable HSM backup/restore tests (#26123)

* feat(resourcemanager): add `TypeReferenceTypeAttribute` (#26127)

Add an attribute which can be used to mark `x-ms-mgmt-typeReferenceType`

part of Azure/autorest.csharp#1761

* Disable missed backup/restore test (#26142)

* Rework binding configuration in Table extension (#26111)

* Add Microsoft.Azure.WebJobs.Extensions.Tables to artifacts (#26145)

* Sync eng/common directory with azure-sdk-tools for PR 2464 (#26143)

* Support AAD graph and Microsoft Graph service principal APIs

* Consolidate service principal wrapper creation

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>

* remove one instrument operation (#26113)

* Rename Parameters to Options

* Remove [TaggedResource]

* Revert "Remove [TaggedResource]"

This reverts commit 4ab3584.

Co-authored-by: Chengming Ruan (WICRESOFT NORTH AMERICA LTD) <v-cruan@microsoft.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Pavel Krymets <pavel@krymets.com>
Co-authored-by: changlong-liu <59815250+changlong-liu@users.noreply.github.com>
Co-authored-by: ArcturusZhang <dapzhang@microsoft.com>
Co-authored-by: Feng Zhou <55177366+fengzhou-msft@users.noreply.github.com>
Co-authored-by: Pratima Upadhyay <pratima.upadhyay02@gmail.com>
Co-authored-by: Yao Kou <yaokou@microsoft.com>
Co-authored-by: Mingzhe Huang <archerzz@users.noreply.github.com>
Co-authored-by: Arthur Ma <arthurma@microsoft.com>
Co-authored-by: John Call <johncall@microsoft.com>
Co-authored-by: Ken Dale <ken@kendaleiv.com>
Co-authored-by: Boby <73424060+bobychaudhary@users.noreply.github.com>
Co-authored-by: Heath Stewart <heaths@microsoft.com>
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yao725 Yao725 Yao725 approved these changes

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

@archerzz archerzz Awaiting requested review from archerzz archerzz is a code owner

@fengzhou-msft fengzhou-msft Awaiting requested review from fengzhou-msft

@m-nash m-nash Awaiting requested review from m-nash

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina

@tg-msft tg-msft Awaiting requested review from tg-msft

@benbp benbp Awaiting requested review from benbp

@chidozieononiwu chidozieononiwu Awaiting requested review from chidozieononiwu

@weshaggard weshaggard Awaiting requested review from weshaggard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArcturusZhang @Yao725