Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use common switch for mgmt plane to turn off new proxy #26003

Merged
merged 2 commits into from
Dec 20, 2021
Merged

use common switch for mgmt plane to turn off new proxy #26003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11b6a33
use common switch
m-nash Dec 17, 2021
5cc2015
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-net int…
m-nash Dec 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions common/ManagementTestShared/Redesign/ManagementRecordedTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,14 @@ public abstract class ManagementRecordedTestBase<TEnvironment> : RecordedTestBas
private ArmClient _cleanupClient;
private bool _waitForCleanup;

protected ManagementRecordedTestBase(bool isAsync, bool useLegacyTransport = false) : base(isAsync, useLegacyTransport: useLegacyTransport)
protected ManagementRecordedTestBase(bool isAsync, bool useLegacyTransport = true) : base(isAsync, useLegacyTransport: useLegacyTransport)
{
SessionEnvironment = new TEnvironment();
SessionEnvironment.Mode = Mode;
Initialize();
}

protected ManagementRecordedTestBase(bool isAsync, RecordedTestMode mode, bool useLegacyTransport = false) : base(isAsync, mode, useLegacyTransport)
protected ManagementRecordedTestBase(bool isAsync, RecordedTestMode mode, bool useLegacyTransport = true) : base(isAsync, mode, useLegacyTransport)
m-nash marked this conversation as resolved.
Show resolved Hide resolved
{
SessionEnvironment = new TEnvironment();
SessionEnvironment.Mode = Mode;
Expand Down
4 changes: 2 additions & 2 deletions sdk/compute/Azure.ResourceManager.Compute/tests/ComputeTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ public class ComputeTestBase : ManagementRecordedTestBase<ComputeTestEnvironment
protected Location DefaultLocation => Location.WestUS2;
protected ArmClient Client { get; private set; }
protected Subscription DefaultSubscription { get; private set; }
public ComputeTestBase(bool isAsync) : base(isAsync, useLegacyTransport: true)
public ComputeTestBase(bool isAsync) : base(isAsync)
{
}

public ComputeTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode, useLegacyTransport: true)
public ComputeTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode)
{
}

Expand Down
4 changes: 2 additions & 2 deletions sdk/deviceupdate/Azure.ResourceManager.DeviceUpdate/tests/DeviceUpdateManagementTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ public class DeviceUpdateManagementTestBase : ManagementRecordedTestBase<DeviceU
protected ArmClient Client { get; private set; }

protected DeviceUpdateManagementTestBase(bool isAsync, RecordedTestMode mode)
: base(isAsync, mode, useLegacyTransport: true)
: base(isAsync, mode)
{
}

protected DeviceUpdateManagementTestBase(bool isAsync)
: base(isAsync, useLegacyTransport: true)
: base(isAsync)
{
}

Expand Down
4 changes: 2 additions & 2 deletions sdk/eventhub/Azure.ResourceManager.EventHubs/tests/Helpers/EventHubTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ public class EventHubTestBase:ManagementRecordedTestBase<EventHubsManagementTest
internal const string DefaultNamespaceAuthorizationRule = "RootManageSharedAccessKey";
protected Subscription DefaultSubscription;
protected ArmClient Client { get; private set; }
protected EventHubTestBase(bool isAsync) : base(isAsync, useLegacyTransport: true)
protected EventHubTestBase(bool isAsync) : base(isAsync)
{
Sanitizer = new EventHubRecordedTestSanitizer();
}

public EventHubTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode, useLegacyTransport: true)
public EventHubTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode)
{
Sanitizer = new EventHubRecordedTestSanitizer();
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/keyvault/Azure.ResourceManager.KeyVault/tests/VaultOperationsTestsBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public abstract class VaultOperationsTestsBase : ManagementRecordedTestBase<KeyV
public ResourceGroup ResourceGroup { get; set; }

protected VaultOperationsTestsBase(bool isAsync)
: base(isAsync, useLegacyTransport: true)
: base(isAsync)
{
}

Expand Down
4 changes: 2 additions & 2 deletions sdk/network/Azure.ResourceManager.Network/tests/Helpers/NetworkServiceClientTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ namespace Azure.ResourceManager.Network.Tests.Helpers
public class NetworkServiceClientTestBase : ManagementRecordedTestBase<NetworkManagementTestEnvironment>
{
private const string dummySSHKey = "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQC+wWK73dCr+jgQOAxNsHAnNNNMEMWOHYEccp6wJm2gotpr9katuF/ZAdou5AaW1C61slRkHRkpRRX9FA9CYBiitZgvCCz+3nWNN7l/Up54Zps/pHWGZLHNJZRYyAB6j5yVLMVHIHriY49d/GZTZVNB8GoJv9Gakwc/fuEZYYl4YDFiGMBP///TzlI4jhiJzjKnEvqPFki5p2ZRJqcbCiF4pJrxUQR/RXqVFQdbRLZgYfJ8xGB878RENq3yQ39d8dVOkq4edbkzwcUmwwwkYVPIoDGsYLaRHnG+To7FvMeyO7xDVQkMKzopTQV8AuKpyvpqu0a9pWOMaiCyDytO7GGN you@me.com";
public NetworkServiceClientTestBase(bool isAsync) : base(isAsync, useLegacyTransport: true)
public NetworkServiceClientTestBase(bool isAsync) : base(isAsync)
{
}

public NetworkServiceClientTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode, useLegacyTransport: true)
public NetworkServiceClientTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode)
{
}

Expand Down
4 changes: 2 additions & 2 deletions sdk/resourcemanager/Azure.ResourceManager/tests/Scenario/ResourceManagerTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ public class ResourceManagerTestBase : ManagementRecordedTestBase<ResourceManage
protected ArmClient Client { get; private set; }

protected ResourceManagerTestBase(bool isAsync, RecordedTestMode mode)
: base(isAsync, mode, useLegacyTransport: true)
: base(isAsync, mode)
{
}

protected ResourceManagerTestBase(bool isAsync)
: base(isAsync, useLegacyTransport: true)
: base(isAsync)
{
}

Expand Down
4 changes: 2 additions & 2 deletions sdk/resources/Azure.ResourceManager.Resources/tests/ResourcesTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ public class ResourcesTestBase : ManagementRecordedTestBase<ResourcesTestEnviron
protected ArmClient Client { get; private set; }

protected ResourcesTestBase(bool isAsync, RecordedTestMode mode)
: base(isAsync, mode, useLegacyTransport: true)
: base(isAsync, mode)
{
}

protected ResourcesTestBase(bool isAsync)
: base(isAsync, useLegacyTransport: true)
: base(isAsync)
{
}

Expand Down
4 changes: 2 additions & 2 deletions sdk/servicebus/Azure.ResourceManager.ServiceBus/tests/Helpers/ServiceBusTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ public class ServiceBusTestBase: ManagementRecordedTestBase<ServiceBusManagement
internal const string DefaultNamespaceAuthorizationRule = "RootManageSharedAccessKey";
protected Subscription DefaultSubscription;
protected ArmClient Client { get; private set; }
protected ServiceBusTestBase(bool isAsync) : base(isAsync, useLegacyTransport: true)
protected ServiceBusTestBase(bool isAsync) : base(isAsync)
{
Sanitizer = new ServiceBusRecordedTestSanitizer();
}
protected ServiceBusTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode, useLegacyTransport: true)
protected ServiceBusTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode)
{
Sanitizer = new ServiceBusRecordedTestSanitizer();
}
Expand Down
4 changes: 2 additions & 2 deletions sdk/storage/Azure.ResourceManager.Storage/tests/Helpers/StorageTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ public class StorageTestBase : ManagementRecordedTestBase<StorageManagementTestE
};
protected ArmClient Client { get; private set; }
protected Subscription DefaultSubscription { get; private set; }
protected StorageTestBase(bool isAsync) : base(isAsync, useLegacyTransport: true)
protected StorageTestBase(bool isAsync) : base(isAsync)
{
}

public StorageTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode, useLegacyTransport: true)
public StorageTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode)
{
}

Expand Down