Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/lexie/task12097662 test #25801

Closed
wants to merge 5 commits into from
Closed

Dev/lexie/task12097662 test #25801

wants to merge 5 commits into from

Conversation

xielexie
Copy link
Contributor

@xielexie xielexie commented Dec 8, 2021

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@ghost ghost added Compute customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Dec 8, 2021
@ghost
Copy link

ghost commented Dec 8, 2021

Thank you for your contribution @xielexie! We will review the pull request and get back to you soon.

@ghost ghost added the Community Contribution Community members are working on the issue label Dec 8, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Oct 16, 2023
@libc16 @ChunyuMSFT
@shail2208 @ZhidaLiu @ac923 @chaoyu-msft @mastloui-msft
CodeGen from PR 26104 in Azure/azure-rest-api-specs
836c9a4 
Release machinelearningservices microsoft.machine learning services 2023 10 01 shadow (Azure#26104)

* Adds base for updating Microsoft.MachineLearningServices from version stable/2023-04-01 to version 2023-10-01

* fix rebase

* Updates API version in new specs and examples

* mfe.json update description to fix linting errors (Azure#24968)

Co-authored-by: Kayla Ames <kaseager@microsoft.com>

* add headers for start/stop/restart compute examples (Azure#25072)

* Adding SubscriptionId and ResourceGroup for Azure Datastore (Azure#25289)

* Add query param in list job api (#25374)

Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com>

* [MachineLearning]Try fixing some lint error in 10-01 version (Azure#25519)

* Try fixing some lint error

* bug fix

* remove unused definition

* Update Example

* adding queue settings to Oct 2023 stable api version (Azure#25765)

* adding queue settings to Oct 2023 stable api version

* update new line

---------

Co-authored-by: Aaheli Chattopadhyay <aahelic@microsoft.com>

* remove job priority (Azure#25775)

Co-authored-by: Aaheli Chattopadhyay <aahelic@microsoft.com>

* Adding MachineLearningService workspace resource publish API and registry datareference API (Azure#25619)

* Adding machinelearningservices workspace publish and registry
datareference API

* minimize diff

* minor updates on put job api summary

* remove two unneeded APIs

* remove extra adding long running annotation

* Add managed Vnet to stable version (Azure#25729)

* Add managed Vnet to stable version

* update missing parameter

* Update missing ref

* meaningless commit trigger pipeline again

* Revert "meaningless commit trigger pipeline again"

This reverts commit baa386b8cf0abb96b461a27d9060188e7ed0581e.

* add missing ref

* Update example version

* trigger pipeline

* Revert "trigger pipeline"

This reverts commit f989c4c91ca85dde28fa636ed82ba9c742a05db9.

* add force to purge parameter

* trigger pipeline

* Revert "trigger pipeline"

This reverts commit 42ea0f8c2dc17e42757112b279fae42a4dc6e557.

* Update examples

* Add format and update examples

* [Model Monitoring][GA] - Add model monitoring scenarios (Azure#25801)

* Add model monitoring scenarios

* add

* add

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* add ws vnet properties (Azure#25882)

Co-authored-by: Aaheli Chattopadhyay <aahelic@microsoft.com>

* Fix circular reference 2023-10-01 (Azure#25879)

* TriggerType->ComputeTriggerType

* RecurrenceFrequency->ComputeRecurrenceFrequency

* RecurrenceSchedule->ComputeRecurrenceSchedule

* description

---------

Co-authored-by: Kayla Ames <kaseager@microsoft.com>

* Adding proxy resource (Azure#25904)

Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com>

* Add feature store api's to GA version (Azure#25594)

* Add examples

* Adding feature store GA api's

* Sync examples

* Add examples

* Converting to ProxyResource

---------

Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com>

* add serverless compute settings (Azure#26012)

Co-authored-by: Aaheli Chattopadhyay <aahelic@microsoft.com>

* [MachineLearningService]Add featurestore property to stable version (Azure#26121)

* Add workspace kind and featureStoreSettings

* add description

* Add description for ComputeRuntimeDti

* remove featurestore settings for lint

* remove Kind

* Revert "remove featurestore settings for lint"

This reverts commit f4d7ae352baf966aeba9085bd06df3456bd17bef.

* Update readme

fix

---------

Co-authored-by: Kayla Ames <kaseager@microsoft.com>
Co-authored-by: libc16 <88697960+libc16@users.noreply.github.com>
Co-authored-by: Chunyu Li <79233053+ChunyuMSFT@users.noreply.github.com>
Co-authored-by: shail2208 <59747407+shail2208@users.noreply.github.com>
Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com>
Co-authored-by: ZhidaLiu <zhili@microsoft.com>
Co-authored-by: ac923 <aahelic@yahoo.com>
Co-authored-by: Aaheli Chattopadhyay <aahelic@microsoft.com>
Co-authored-by: chaoyu-msft <93601904+chaoyu-msft@users.noreply.github.com>
Co-authored-by: Mathieu St-Louis <81435026+mastloui-msft@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archerzz archerzz Awaiting requested review from archerzz archerzz is a code owner

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang ArcturusZhang is a code owner

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

@fengzhou-msft fengzhou-msft Awaiting requested review from fengzhou-msft

@m-nash m-nash Awaiting requested review from m-nash

@Yao725 Yao725 Awaiting requested review from Yao725

Assignees

@m-nash m-nash

Labels
Community Contribution Community members are working on the issue Compute customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xielexie @grizzlytheodore @m-nash