Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added az networking api for 2021-05-01 version #24883

Merged
merged 11 commits into from
Oct 28, 2021
Merged

Added az networking api for 2021-05-01 version #24883

merged 11 commits into from
Oct 28, 2021

Conversation

MikhailTryakhov
Copy link
Contributor

@MikhailTryakhov MikhailTryakhov commented Oct 22, 2021

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
    

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@allenjzhang
Copy link
Member

The metadata file was not included. But interestingly enough, the codegen verification did NOT fail. Need to take a look.

@MikhailTryakhov
Copy link
Contributor Author

Fixed metadata + regenerated.
@Yao725 can you please review and merge it ASAP?

@Yao725
Copy link
Member

Yao725 commented Oct 25, 2021

@MikhailTryakhov approved, but please fix the failed build.

@MikhailTryakhov
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@MikhailTryakhov
Copy link
Contributor Author

@Yao725 can you please help me to rerun these jobs? They were succeeded last time
Can't get what's happened

Copy link
Member

@archerzz archerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikhailTryakhov Generally it's good. Just spotted a breaking change and some places need customization for backward compatibility.

  • If the breaking change is expected, then you can update the major version and you don't need to provide customization.

@MikhailTryakhov
Copy link
Contributor Author

@archerzz changed sdk version, please review/merge in case it's ok for you

@MikhailTryakhov
Copy link
Contributor Author

@archerzz @Yao725 can you please help to understand what hapened with failures we have magically right from now?

@Yao725
Copy link
Member

Yao725 commented Oct 26, 2021

Hi @MikhailTryakhov , it looks like that there is something wrong with the provided commit id . The ci failed here because the link just points to a readme.md which doesn't exist, so please correct it.

@MikhailTryakhov
Copy link
Contributor Author

@Yao725 can we sync up quickly? I can't find any ways to generate this metadata (ran Start-AutoRestCodeGeneration - same data generated, updated PR)
how can we move it? Which data should be presented? Pls help

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.

@archerzz
Copy link
Member

@MikhailTryakhov In the network_resource-manager.txt, you've updated the commit ID to ed2922ddb7c7477a2f08551316cfa61291556354. But actually it doesn't exist (e.g. https://github.com/Azure/azure-rest-api-specs/blob/ed2922ddb7c7477a2f08551316cfa61291556354/specification/network/resource-manager/readme.md)

@MikhailTryakhov
Copy link
Contributor Author

@archerzz @Yao725 I can't open this link, sorry
Can you please help me to finalize it successfully?

@MikhailTryakhov
Copy link
Contributor Author

hey @archerzz @Yao725 looks like I found the right commit ID but by some reason receiving timeout exceptions (100m limit exceeded)
Can you please help to figure out what's up here?

@archerzz
Copy link
Member

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MikhailTryakhov
Copy link
Contributor Author

@archerzz @Yao725 failure again due to timeout. can you please help to figure out? We're here for 5th day already :(

@archerzz
Copy link
Member

@MikhailTryakhov It's a known issue for RPs having large swagger files. I've re-started the failed job, and will keep an eye on it. The SDK should be ready to go, just needs to pass the build... Hopefully when track2 is GA, we don't need to suffer from this again.

@archerzz archerzz merged commit 688a906 into main Oct 28, 2021
@archerzz archerzz deleted the mitryakh/05-01 branch October 28, 2021 08:14
@MikhailTryakhov
Copy link
Contributor Author

Thanks a lot @archerzz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants