[Event Hubs] Assorted Minor Updates #23655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquire
added
Event Hubs
Client
jsquire
requested review from
christothes,
conniey,
serkantkaraca and
JoshLove-msft
|
/azp run net - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsquire
commented
Aug 30, 2021
jsquire
force-pushed
the
eventhubs/docs
branch
2 times, most recently
from
e5fa175
to
50270d1
Compare
|
/azp run net - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
christothes
approved these changes
Aug 30, 2021
sdk/eventhub/Azure.Messaging.EventHubs/src/Amqp/AmqpConnectionScope.cs
Outdated
Show resolved
Hide resolved
jsquire
force-pushed
the
eventhubs/docs
branch
from
50270d1
to
3a45570
Compare
|
/azp run net - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
The focus of these changes is to: - Update change logs - Refine documentation around event handlers in the buffered producer - Adapt to changes in the `TestEnvironment` that altered behavior - Fix a corner case in the AmqpScope that could lead to timers not being properly disposed in some error scenarios. - Fix minor formatting and a test issue in a sample.
jsquire
force-pushed
the
eventhubs/docs
branch
from
3a45570
to
9afa5bf
Compare
|
Hello @jsquire! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Apr 23, 2023
Gauravkumar1491 resources microsoft.resources 2022 12 01 update readme.md (Azure#23655) * updating correct tag * removing unwanted changes
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The focus of these changes is to:
TestEnvironmentthat altered behaviorAmqpConnectionScopethat could lead to timers not being properly disposed in some error scenarios.