-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add InProc dependency type and update db target mapping. #23541
Add InProc dependency type and update db target mapping. #23541
Conversation
vishweshbankwar
commented
Aug 25, 2021
- InProc type should be used for all the in-process spans (Part B Span.kind == SpanKind.INTERNAL) with parent
- For db target:
- If target derived from peerService or net* attributes is not null, then append Span.dbName (if present) using / delimiter.
- If target derived from peerService or net* attributes is null, then assign Span.dbName (if present) to target.
- Default: If none of the above are available, assign Span.dbSystem to target.
…roc-DependencyType-And-UpdateDBTarget
{ | ||
string target = tagObjects.GetDependencyTarget(PartBType.Db); | ||
string dbName = AzMonList.GetTagValue(ref tagObjects, SemanticConventions.AttributeDbName)?.ToString(); | ||
if (!string.IsNullOrEmpty(target) && !string.IsNullOrEmpty(dbName)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Instead of checking the string content several times. We could enable check once earlier and based on its flag we could validate in if-else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! I think we probably need some perf benchmark and numbers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - it is in my todo list.
Adding a new stable API-version 2023-05-01 (Azure#23541) * Base commit from 2023-01-01 * Changing version from 2023-01-01 to 2023-05-01 * Adding Hooks changes in the new API version * Updating readme files of Microsoft.Dataprotection --------- Co-authored-by: SHASHANK SINGH <shashasingh@microsoft.com>
Revert "Adding a new stable API-version 2023-05-01 (Azure#23541)" (Azure#23647) This reverts commit c655f508b77a442f106250c1ced44ee40e110b00.