Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump core version and fix errordetail reference #23478

Merged
merged 3 commits into from
Aug 23, 2021
Merged

bump core version and fix errordetail reference #23478

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a3782e
mark test as playback only
m-nash Aug 23, 2021
9f05754
updated wrong package
m-nash Aug 23, 2021
46bbdad
update api
m-nash Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Packages.Data.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@
All should have PrivateAssets="All" set so they don't become pacakge dependencies
-->
<ItemGroup>
<PackageReference Update="Microsoft.Azure.AutoRest.CSharp" Version="3.0.0-beta.20210822.2" PrivateAssets="All" />
<PackageReference Update="Microsoft.Azure.AutoRest.CSharp" Version="3.0.0-beta.20210822.3" PrivateAssets="All" />
<PackageReference Update="Azure.ClientSdk.Analyzers" Version="0.1.1-dev.20210601.1" PrivateAssets="All" />
<PackageReference Update="coverlet.collector" Version="1.3.0" PrivateAssets="All" />
<PackageReference Update="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.3.1" PrivateAssets="All" />
Expand Down
1 change: 1 addition & 0 deletions sdk/core/Azure.Core/tests/ManagementPipelineBuilderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ public void AddPerCallPolicy()

[RecordedTest]
[SyncOnly]
[PlaybackOnly("Not intended for live tests")]
public void AddPerCallPolicyViaClient()
{
var options = InstrumentClientOptions(new ArmClientOptions());
Expand Down
4 changes: 2 additions & 2 deletions ...ceManager/src/PsuedoGenerated/Resources/Models/ResourceGroupExportResult.Serialization.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public partial class ResourceGroupExportResult
internal static ResourceGroupExportResult DeserializeResourceGroupExportResult(JsonElement element)
{
Optional<object> template = default;
Optional<ErrorResponse> error = default;
Optional<ErrorDetail> error = default;
foreach (var property in element.EnumerateObject())
{
if (property.NameEquals("template"))
Expand All @@ -35,7 +35,7 @@ internal static ResourceGroupExportResult DeserializeResourceGroupExportResult(J
property.ThrowNonNullablePropertyIsNull();
continue;
}
error = ErrorResponse.DeserializeErrorResponse(property.Value);
error = ErrorDetail.DeserializeErrorDetail(property.Value);
continue;
}
}
Expand Down
4 changes: 2 additions & 2 deletions ...r/Azure.ResourceManager/src/PsuedoGenerated/Resources/Models/ResourceGroupExportResult.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ internal ResourceGroupExportResult()
/// <summary> Initializes a new instance of ResourceGroupExportResult. </summary>
/// <param name="template"> The template content. </param>
/// <param name="error"> The template export error. </param>
internal ResourceGroupExportResult(object template, ErrorResponse error)
internal ResourceGroupExportResult(object template, ErrorDetail error)
{
Template = template;
Error = error;
Expand All @@ -27,6 +27,6 @@ internal ResourceGroupExportResult(object template, ErrorResponse error)
/// <summary> The template content. </summary>
public object Template { get; }
/// <summary> The template export error. </summary>
public ErrorResponse Error { get; }
public ErrorDetail Error { get; }
}
}