Smoke test isolation per package #23310
Conversation
ckairen
requested review from
AlexGhiondea,
chidozieononiwu,
danieljurek,
heaths,
jsquire,
schaabs,
tg-msft and
weshaggard
as code owners
| @@ -22,6 +22,9 @@ | |||
|
|
|||
| <!-- This is needed to resolve a build conflict and force the correct version --> | |||
| <PackageReference Include="System.Net.NameResolution" Version="4.3.0" /> | |||
|
|
|||
| <!-- This is needed for non-nightly smoke test runs --> | |||
| <PackageReference Include="Azure.Template" Version="1.0.2" /> | |||
There was a problem hiding this comment.
Can you help me understand why the template project needs to be referenced? Nothing published should be using it.
There was a problem hiding this comment.
@ckairen correct me if I'm wrong but I suspect he added it so that he can use the template package to test these changes.
There was a problem hiding this comment.
Yes this one is for testing the template package
| } | ||
| name: check_smoke_tests_${{ artifact.safeName }} | ||
| displayName: Check smoke test eligibility for ${{ artifact.name }} | ||
| - ${{ if and(ne(variables['Skip.Release'], 'true'), ne(parameters.Artifact.skipPublishPackage, 'true')) }}: |
There was a problem hiding this comment.
Lets ensure that we are correctly scoping to the exact package we are releasing.
There was a problem hiding this comment.
Yeah, it should be already scoped to the exact released package.
Downloaded Version:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1046302&view=logs&j=b61764e4-2b38-5b4a-c599-d8da1081f4df&t=cd24fc2b-7cf2-5fb4-71f5-499205e750fb&l=162
| Daily: false | ||
| Artifacts: ${{ parameters.Artifacts }} | ||
| ArtifactName: ${{ parameters.ArtifactName }} | ||
| - ${{if and(eq(variables['Build.Reason'], 'Manual'), eq(variables['System.TeamProject'], 'internal'))}}: |
There was a problem hiding this comment.
FWIW, I changed ".com" to ".dev" and it made this change much easier to visualize: https://github.dev/Azure/azure-sdk-for-net/pull/23310
I see it puts it equivalent with the previous - ${{if}} on line 201, thus making it part of each artifact's Release stage.
This isolates the smoke tests by running it per package, rather than after the entire release, as discussed here: Azure/azure-sdk-tools#1841
Pipeline ref: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1046302&view=results
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draftmode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]orAzure.ResourceManager.[RP]Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new servicelabel and/or contact assigned reviewer.If the check fails at the
Verify Code Generationstep, please ensure:generate.ps1/cmdto generate this PR instead of callingautorestdirectly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.