Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename tagoperatoins property #23280

Merged
merged 18 commits into from
Aug 12, 2021
Merged

rename tagoperatoins property #23280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
10a29b4
update simple resources to no longer have operations
m-nash Aug 9, 2021
9891c21
combine genericResource and genericResourceExpanded
m-nash Aug 9, 2021
f43da5b
combine managementGroupInfo and manageGroup
m-nash Aug 9, 2021
bc70e38
update core tests after changes
m-nash Aug 9, 2021
03bbd14
update fields to be consistent with autorest
m-nash Aug 9, 2021
f230fd1
update after test interceptor changes
m-nash Aug 9, 2021
c08edf4
update to take resourceidentifier
m-nash Aug 9, 2021
6540f18
update api after changes
m-nash Aug 9, 2021
b2f4abc
add test case to validate bad sub id being passed into armclient
m-nash Aug 10, 2021
91814b4
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-net int…
m-nash Aug 11, 2021
c6d3da5
temporarily use alpha version of core
m-nash Aug 11, 2021
ee31a52
remove unused overload
m-nash Aug 11, 2021
2e0d84b
add recording so test can be played back in ci
m-nash Aug 11, 2021
2b8b9e2
use testenv creds
m-nash Aug 11, 2021
433df03
update tagresource name
m-nash Aug 11, 2021
91f2559
merge from main
m-nash Aug 11, 2021
f71c803
update after merge
m-nash Aug 11, 2021
a9a027d
update api
m-nash Aug 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/resourcemanager/Azure.ResourceManager/api/Azure.ResourceManager.netstandard2.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ protected ArmResource(Azure.ResourceManager.Core.ArmResource parentOperations, A
public virtual Azure.ResourceManager.ResourceIdentifier Id { get { throw null; } }
protected internal virtual Azure.Core.Pipeline.HttpPipeline Pipeline { get { throw null; } }
protected internal Azure.ResourceManager.Resources.TagResourceContainer TagContainer { get { throw null; } }
protected internal Azure.ResourceManager.Resources.TagResource TagResourceOperations { get { throw null; } }
protected internal Azure.ResourceManager.Resources.TagResource TagResource { get { throw null; } }
protected abstract Azure.ResourceManager.ResourceType ValidResourceType { get; }
protected System.Collections.Generic.IEnumerable<Azure.ResourceManager.Resources.Models.Location> ListAvailableLocations(Azure.ResourceManager.ResourceType resourceType, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
protected System.Threading.Tasks.Task<System.Collections.Generic.IEnumerable<Azure.ResourceManager.Resources.Models.Location>> ListAvailableLocationsAsync(Azure.ResourceManager.ResourceType resourceType, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
Expand Down
4 changes: 2 additions & 2 deletions sdk/resourcemanager/Azure.ResourceManager/src/ArmResource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ namespace Azure.ResourceManager.Core
public abstract class ArmResource
{
private TagResourceContainer _tagContainer;
private TagResource _tagResourceOperations;
private TagResource _tagResource;
private Tenant _tenant;

/// <summary>
Expand Down Expand Up @@ -91,7 +91,7 @@ internal ArmResource(ClientContext clientContext, ResourceIdentifier id)
/// Gets the TagResourceOperations.
/// </summary>
/// <returns> A TagResourceOperations. </returns>
Comment on lines 91 to 93
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: TagResourceOperations -> TagResource

protected internal TagResource TagResourceOperations => _tagResourceOperations ??= new TagResource(this, Id);
protected internal TagResource TagResource => _tagResource ??= new TagResource(this, Id);

/// <summary>
/// Gets the TagsOperations.
Expand Down
16 changes: 8 additions & 8 deletions sdk/resourcemanager/Azure.ResourceManager/src/Generated/Resources/GenericResource.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions sdk/resourcemanager/Azure.ResourceManager/src/Generated/Resources/ResourceGroup.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.