Use ILogger<T> for webjob extensions #22362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshLove-msft
requested review from
amishra-dev,
amnguye,
fabiocav,
jsquire,
kasobol-msft,
mathewc,
pakrym,
seanmcc-msft,
serkantkaraca and
tg-msft
as code owners
ghost
added
JoshLove-msft
commented
Jul 1, 2021
| @@ -28,7 +28,7 @@ internal QueueProcessorOptions(QueueClient queue, ILoggerFactory loggerFactory, | |||
| { | |||
| Queue = queue ?? throw new ArgumentNullException(nameof(queue)); | |||
| PoisonQueue = poisonQueue; | |||
| Logger = loggerFactory?.CreateLogger(LogCategories.CreateTriggerCategory("Queue")); | |||
| Logger = loggerFactory?.CreateLogger<QueueProcessor>(); | |||
There was a problem hiding this comment.
Intentionally used QueueProcessor rather than QueueProcessorOptions as that fits better with the usage.
|
/azp run net - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run net - eventhub - tests |
|
/azp run net - eventgrid - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
kasobol-msft
approved these changes
Jul 1, 2021
jsquire
approved these changes
Jul 1, 2021
pakrym
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22208