Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MetricsAdvisor] Multiple classes and properties renames #22273

Merged
merged 7 commits into from
Jun 29, 2021

Conversation

kinelski
Copy link
Member

@kinelski kinelski commented Jun 29, 2021

PR looks big because of the generated code, but here's an exhaustive list of changes. Class renames are usually accompanied by property renames. Property renames are sometimes accompanied by constructor parameter renames.

Cross-language consistency:

  • Renamed class MetricAnomalyAlertConfigurationsOperator to DetectionConditionOperator.

Architects feedback:

  • Discriminators should be named Kind, not Type. Also, the name FeedbackKind is too generic.
    • Renamed class DataSourceType to DataSourceKind.
    • Renamed class FeedbackType to MetricFeedbackKind.
  • Name too generic.
    • Renamed class PeriodType to MetricPeriodType.
  • New name sounds better.
    • In DataFeed, renamed AdministratorsEmails to AdministratorEmails, and ViewersEmails to ViewerEmails.
    • In NotificationHook, renamed AdministratorsEmails to AdministratorEmails.
    • In ChangeThresholdCondition, renamed IsWithinRange to WithinRange.
  • Links should use the suffix Uri instead of Link in .NET.
    • In NotificationHook, renamed ExternalLink to ExternalUri.
  • Consistency with other properties in the library.
    • In MetricAnomalyFeedback, renamed AnomalyDetectionConfigurationId to DetectionConfigurationId, and AnomalyDetectionConfigurationSnapshot to DetectionConfigurationSnapshot.

@kinelski kinelski added the Client This issue points to a problem in the data-plane of the library. label Jun 29, 2021
@kinelski kinelski requested a review from maririos June 29, 2021 15:14
@kinelski kinelski self-assigned this Jun 29, 2021
@kinelski kinelski merged commit 2a59cde into Azure:main Jun 29, 2021
@kinelski kinelski deleted the ma-renames branch June 29, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants