Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove autorest models with internal properties #22259

Merged
merged 5 commits into from
Jun 29, 2021
Merged

Remove autorest models with internal properties #22259

merged 5 commits into from
Jun 29, 2021

Conversation

AlexanderSher
Copy link
Contributor

No description provided.

@pakrym
Copy link
Contributor

pakrym commented Jun 28, 2021

Can we get rid of https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/eventgrid/Azure.Messaging.EventGrid/src/Customization/EventGridModelFactory.cs#L11-L19 ?

@pakrym pakrym mentioned this pull request Jun 28, 2021
Merged
annelo-msft
annelo-msft reviewed Jun 28, 2021
View reviewed changes
Copy link
Member

@annelo-msft annelo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For ACR, this is removing a model type that customers may still want to mock ... are there plans to replace the methods in model factory so they can be created with only the public properties?

@AlexanderSher
Copy link
Contributor Author

@annelo-msft The problem is that we can't be sure that public properties are enough for the model to be fully initialized, so we can't simply supply default values for property types.

JoshLove-msft
JoshLove-msft approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@JoshLove-msft JoshLove-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EG changes look good

christothes
christothes approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@christothes christothes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tables looks good

@AlexanderSher
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-net int…
c278490 
…o RemoveInternalFields

# Conflicts:
#	sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/Generated/MicrosoftAzureMetricsAdvisorRestAPIOpenAPIV2ModelFactory.cs
@AlexanderSher AlexanderSher merged commit 2348056 into Azure:main Jun 29, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Feb 3, 2023
CodeGen from PR 22259 in Azure/azure-rest-api-specs
7be9f3f 
Fix runningOperationIds data type (Azure#22259)

* Fix runningOperationIds data type

* Fix PR comments
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Feb 3, 2023
CodeGen from PR 22259 in Azure/azure-rest-api-specs
aa17cee 
Fix runningOperationIds data type (Azure#22259)

* Fix runningOperationIds data type

* Fix PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annelo-msft annelo-msft annelo-msft left review comments

@christothes christothes christothes approved these changes

@pakrym pakrym pakrym approved these changes

@JoshLove-msft JoshLove-msft JoshLove-msft approved these changes

@ahamad-MS ahamad-MS Awaiting requested review from ahamad-MS

@AlexGhiondea AlexGhiondea Awaiting requested review from AlexGhiondea

@chidozieononiwu chidozieononiwu Awaiting requested review from chidozieononiwu

@danieljurek danieljurek Awaiting requested review from danieljurek

@jfggdl jfggdl Awaiting requested review from jfggdl

@kinelski kinelski Awaiting requested review from kinelski kinelski is a code owner

@Kishp01 Kishp01 Awaiting requested review from Kishp01 Kishp01 is a code owner

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina KrzysztofCwalina is a code owner

@LarryOsterman LarryOsterman Awaiting requested review from LarryOsterman

@maririos maririos Awaiting requested review from maririos

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@tg-msft tg-msft Awaiting requested review from tg-msft tg-msft is a code owner

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

Assignees
No one assigned
Labels
Cognitive - Metrics Advisor Event Grid Tables
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AlexanderSher @pakrym @christothes @annelo-msft @JoshLove-msft @azure-sdk