Always set otel.status_code #22115
Merged
Always set otel.status_code #22115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
christothes
reviewed
Jun 23, 2021
| @@ -61,9 +61,9 @@ public async Task ActivityIsCreatedForRequest() | |||
| CollectionAssert.Contains(activity.Tags, new KeyValuePair<string, string>("http.user_agent", "agent")); | |||
| CollectionAssert.Contains(activity.Tags, new KeyValuePair<string, string>("requestId", clientRequestId)); | |||
| CollectionAssert.Contains(activity.Tags, new KeyValuePair<string, string>("serviceRequestId", "server request id")); | |||
| CollectionAssert.Contains(activity.Tags, new KeyValuePair<string, string>("otel.status_code", "UNSET")); | |||
There was a problem hiding this comment.
Do we have a test that validates it being set to "ERROR"?
There was a problem hiding this comment.
lmolkova
approved these changes
Jun 23, 2021
| else | ||
| { | ||
| // Set the status to UNSET so the AppInsights doesn't try to infer it from the status code | ||
| activity.AddTag("otel.status_code", "UNSET"); |
There was a problem hiding this comment.
is otel.status_code supported by appInsights SDK to populate success? It looks like only EventHub listener is aware of it
There was a problem hiding this comment.
the listener you linked (https://github.com/microsoft/ApplicationInsights-dotnet/blob/53a4422d01dbd068baaaeecc1ee9f2fb74fc82e9/WEB/Src/DependencyCollector/DependencyCollector/Implementation/AzureSdk/AzureSdkDiagnosticsEventHandler.cs) is used for all azure SDK activities including HTTP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it so the later versions of AppInsights don't have to infer the http span success based on the HTTP status code.
ResponseClassifier implementations that Azure SDKs provide have more context and better logic so flow the information through.
The actual customer experience depends on microsoft/ApplicationInsights-dotnet#2200