-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable INT Tests for Communication CallingServer SDK. #22050
Conversation
SKIP_CALLINGSERVER_INTERACTION_LIVE_TESTS: TRUE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you still need this flag? SKIP_CALLINGSERVER_INTERACTION_LIVE_TESTS now that you remove the INT from Clouds config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we still need it. This flag is used to skip tests required human Interaction(like pick up the call) Which cannot be perform in Live Mode test pipeline.
@@ -15,9 +15,9 @@ extends: | |||
SubscriptionConfigurations: | |||
- $(sub-config-communication-int-test-resources-common) | |||
- $(sub-config-communication-int-test-resources-net) | |||
Clouds: Public,Int | |||
Clouds: Public | |||
EnvVars: | |||
# SKIP_PHONENUMBER_LIVE_TESTS skips certain phone number tests such as purchase and release | |||
SKIP_PHONENUMBER_LIVE_TESTS: TRUE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we have SKIP_PHONENUMBER_LIVE_TESTS in the CallingServer tests.yml? Is it a copy/paste mistake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed. Yes, I think so. Also this SKIP_PHONENUMBER_LIVE_TESTS is appeared in others' sdk test.yml file as well, might need to clean up as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting it. Please feel free to clean those too in your future PRs. I am sure the owners of those projects will appreciate it 😊
LGTM, thanks Zihan |
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new service
label and/or contact assigned reviewer.If the check fails at the
Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1
. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1
to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.