Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zihzhan/fix #21905

Merged
merged 22 commits into from
Jun 16, 2021
Merged

Zihzhan/fix #21905

merged 22 commits into from
Jun 16, 2021

Conversation

zihzhan-msft
Copy link
Member

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@zihzhan-msft
Update Snippet and Export-API.
dee33cf
@zihzhan-msft
remove calloption override in servercall client.
818dc1b
@zihzhan-msft
Nit for params and arguments handling.
3b3d50e
@zihzhan-msft
Merge branch 'feature/callingServer-preview1-enhancement' of https://…
aa107fc 
…github.com/Azure/azure-sdk-for-net into zihzhan/fix
@zihzhan-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-net i…
8b69016 
…nto zihzhan/fix
@zihzhan-msft
Merge Downloader updates.
c6baf82
@zihzhan-msft
Merge Downloader updates test cases.
3aa15a0
@zihzhan-msft
Update AutoGen Content.
fcdae81
@zihzhan-msft
Resolve merge conflict.
65ba2cd
@zihzhan-msft
Nit clean on Unit Tests.
f62e7cd
@zihzhan-msft
Merge branch 'feature/callingServer-preview1-enhancement' of https://…
3e56bef 
…github.com/Azure/azure-sdk-for-net into zihzhan/fix
@zihzhan-msft
Updating and renaming.
31daa0f
@zihzhan-msft
Merge branch 'feature/callingServer-preview1-enhancement' of https://…
fe9f344 
…github.com/Azure/azure-sdk-for-net into zihzhan/fix
@zihzhan-msft
Merge branch 'feature/callingServer-preview1-enhancement' of https://…
b4c8dbb 
…github.com/Azure/azure-sdk-for-net into zihzhan/fix
@zihzhan-msft
Merge branch 'feature/callingServer-preview1-enhancement' of https://…
0777d49 
…github.com/Azure/azure-sdk-for-net into zihzhan/fix
@zihzhan-msft
Test update.
794122e
@zihzhan-msft
Merge branch 'feature/callingServer-preview1-enhancement' of https://…
f156c31 
…github.com/Azure/azure-sdk-for-net into zihzhan/fix
@zihzhan-msft
Add Call Connection Live Tests.
0525b42
@zihzhan-msft
Add ServerCall Live Tests
7c0519f
@zihzhan-msft
Merge branch 'feature/callingServer-preview1-enhancement' of https://…
9e7a022 
…github.com/Azure/azure-sdk-for-net into zihzhan/fix
@ghost ghost added the Communication label Jun 16, 2021
@zihzhan-msft zihzhan-msft requested review from navali-msft and removed request for tg-msft and KrzysztofCwalina June 16, 2021 16:50
navali-msft
navali-msft reviewed Jun 16, 2021
View reviewed changes
...ation/Azure.Communication.CallingServer/tests/Infrastructure/CallingServerTestEnvironment.cs
@@ -15,13 +15,18 @@ public class CallingServerTestEnvironment : CommunicationTestEnvironment
/// <summary>
/// The phone number associated with the source.
/// </summary>
public string SourcePhoneNumber => GetRecordedVariable(AzurePhoneNumber, options => options.IsSecret());
public string SourcePhoneNumber => GetRecordedVariable(AlternateCallerId, options => options.IsSecret());

/// <summary>
/// The phone number associated with the source.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments/description are not not correct

@zihzhan-msft zihzhan-msft merged commit 2e163e6 into feature/callingServer-preview1-enhancement Jun 16, 2021
@zihzhan-msft zihzhan-msft deleted the zihzhan/fix branch June 16, 2021 17:50
minnieliu pushed a commit that referenced this pull request Jun 21, 2021
@navali-msft @zihzhan-msft @chrwhit
Added enhancements on top of Calling Server preview 1 (#21686)
658dbd4 
* Clean up clients comments.

* Models updates to introduce CallConnection and Server.

* callState updated to callConnectionState, replace sourceAlternateIdentity with alternateCallerId, other fixes

* Update to the test sample.

* Updated the swagger path, removed delete operation, updated unit tests and live tests

* Updates based on comments

* Zihzhan/fix (#21727)

* Clean up clients comments.

* Update Snippet and Export-API.

* Zihzhan/fix (#21764)

* Update Snippet and Export-API.

* remove calloption override in servercall client.

* Nit for params and arguments handling.

* Merge Downloader updates.

* Merge Downloader updates test cases.

* Update AutoGen Content.

* Model name updates (Suffix for responses models now has Result instead of Response), fixes based on comments (#21790)

* Zihzhan/fix (#21805)

* Update Snippet and Export-API.

* remove calloption override in servercall client.

* Nit for params and arguments handling.

* Merge Downloader updates.

* Merge Downloader updates test cases.

* Update AutoGen Content.

* Nit clean on Unit Tests.

* Updating and renaming.

* The changes which are done: (#21863)

InviteParticipants --> AddParticipant
InviteParticipantResultEvent --> AddParticipantResultEvent
CallModality --> MediaType
CommunicationParticipant --> CallParticipant
Id in PlayAudioResult & CancelAllMediaOperations is now called OperationId
CallConnectionState now has {incoming, connecting, connected, disconnecting, disconnected}
CallRecordingStateResult ---> CallRecording... by Naveed Ali
CallRecordingStateResult ---> CallRecordingProperties

* Fix build Anaylse.

* fix(tests): improve code coverage

* Added AddParticipantResult, Re-added communication error, updated swagger path (#21870)

* Added AddParticipantResult, Re-added communication error, updated swagger path

* Fixed unit tests

* Updated netstandard

* Analysis fix

* Updated event type for add participant

* Fix build issue.

* Zihzhan/fix (#21905)

* Update Snippet and Export-API.

* remove calloption override in servercall client.

* Nit for params and arguments handling.

* Merge Downloader updates.

* Merge Downloader updates test cases.

* Update AutoGen Content.

* Nit clean on Unit Tests.

* Updating and renaming.

* Test update.

* Add Call Connection Live Tests.

* Add ServerCall Live Tests

* Increase Test Coverage.

* Reenable sample tests.

* Zihzhan/fix (#21931)

* Update Snippet and Export-API.

* remove calloption override in servercall client.

* Nit for params and arguments handling.

* Merge Downloader updates.

* Merge Downloader updates test cases.

* Update AutoGen Content.

* Nit clean on Unit Tests.

* Updating and renaming.

* Test update.

* Add Call Connection Live Tests.

* Add ServerCall Live Tests

* Increase Test Coverage.

* Reenable sample tests.

* Address comments.

* Point to swagger file in master branch.

* Zihzhan/fix (#21950)

* Update Snippet and Export-API.

* remove calloption override in servercall client.

* Nit for params and arguments handling.

* Merge Downloader updates.

* Merge Downloader updates test cases.

* Update AutoGen Content.

* Nit clean on Unit Tests.

* Updating and renaming.

* Test update.

* Add Call Connection Live Tests.

* Add ServerCall Live Tests

* Increase Test Coverage.

* Reenable sample tests.

* Address comments.

* Point to swagger file in master branch.

* Nit fix.

* Nit changes based on Azure boarder review feedback.

* Address comments.

* Naming changes.

* Change to static connection string.

* Add methods that support Live Test.

* Moved Recorded value inside the test method.

* Updated models definition based on new swagger plus updated events properties to readonly (#21980)

* Updated models definition based on new swagger, also fixed events to make properties readonly

* Update accessibility of internal models

* Update the file path in autorest

* Update auto gen apis.

* Rewrite the event tests and fixed json for other tests (#21983)

* Disable AddParticipant test in Live mode.

* Moved modelfactory to .models namespace (#22021)

Co-authored-by: zihzhan <zihzhan@microsoft.com>
Co-authored-by: Zihan Zhang <43592314+zihzhan-msft@users.noreply.github.com>
Co-authored-by: Christian Whitehead <chrwhit@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navali-msft navali-msft navali-msft approved these changes

Assignees
No one assigned
Labels
Communication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zihzhan-msft @navali-msft