Mark test as inconclusive if doc publish does not start #21859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add asserts to verify all actions are counted for pending queue
Mohit-Chakraborty
requested review from
arv100kri,
bleroy,
brjohnstmsft and
tg-msft
as code owners
ghost
added
the
|
There have been 2 failures in the test in the past 30 days - The live test failure assertion suggests that the document publish did not even start, which has been an issue in a few tests. For that, we now mark the test as inconclusive. I repeated the test up to 5000 times locally, but it did not fail. Hopefully, the new assertions will shed light on such intermittent failures. |
|
/azp run net - search - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
cc: @tg-msft |
tg-msft
reviewed
Jun 15, 2021
sdk/search/Azure.Search.Documents/tests/Batching/BatchingTests.cs
Outdated
Show resolved
Hide resolved
tg-msft
approved these changes
Jun 18, 2021
sdk/search/Azure.Search.Documents/tests/Utilities/SearchTestBase.cs
Outdated
Show resolved
Hide resolved
sdk/search/Azure.Search.Documents/tests/Utilities/SearchTestBase.cs
Outdated
Show resolved
Hide resolved
sdk/search/Azure.Search.Documents/tests/Utilities/SearchTestBase.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: tg-msft <tg-msft@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.