[Synapse] - Build SDK based on API version 2021-04-01-preview and add SQL DW Gen3 API (2020-04-01-preview) #21769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idear1203
requested review from
allenjzhang,
m-nash,
markcowl,
nisha-bhatia and
YalinLi0312
as code owners
idear1203
changed the title
m-nash
requested changes
Jun 15, 2021
| @@ -39,7 +39,7 @@ public OperationResource() | |||
| /// <param name="endTime">Operation start time</param> | |||
| /// <param name="percentComplete">Completion percentage of the | |||
| /// operation</param> | |||
| public OperationResource(string id = default(string), string name = default(string), string status = default(string), object properties = default(object), ErrorDetail error = default(ErrorDetail), System.DateTime? startTime = default(System.DateTime?), System.DateTime? endTime = default(System.DateTime?), double? percentComplete = default(double?)) | |||
| public OperationResource(string id = default(string), string name = default(string), string status = default(string), object properties = default(object), ErrorResponse error = default(ErrorResponse), System.DateTime? startTime = default(System.DateTime?), System.DateTime? endTime = default(System.DateTime?), double? percentComplete = default(double?)) | |||
There was a problem hiding this comment.
this will result in a breaking change, please revert or have the breaking change team add the approval label to the spec pr
| @@ -86,7 +86,7 @@ public OperationResource(string id = default(string), string name = default(stri | |||
| /// Gets or sets errors from the operation | |||
| /// </summary> | |||
| [JsonProperty(PropertyName = "error")] | |||
| public ErrorDetail Error { get; set; } | |||
| public ErrorResponse Error { get; set; } | |||
There was a problem hiding this comment.
this will result in a breaking change, please revert or have the breaking change team add the approval label to the spec pr
| /// Number code, e.g. P3.</param> | ||
| /// <param name="tier">The tier or edition of the particular SKU, e.g. | ||
| /// Basic, Premium.</param> | ||
| public Sku(string name, string tier = default(string)) |
There was a problem hiding this comment.
this will result in a breaking change, please revert or have the breaking change team add the approval label to the spec pr
| /// </summary> | ||
| [JsonProperty(PropertyName = "capacity")] | ||
| public int? Capacity { get; set; } |
There was a problem hiding this comment.
this will result in a breaking change, please revert or have the breaking change team add the approval label to the spec pr
idear1203
force-pushed
the
synapse_generate_code_based_on_latest_swagger_20210609
branch
from
1ab9ecb
to
313b1d0
Compare
idear1203
force-pushed
the
synapse_generate_code_based_on_latest_swagger_20210609
branch
from
5c3dd71
to
a7bcdf2
Compare
m-nash
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
major Swagger PR link: Azure/azure-rest-api-specs#13874
Swagger PR link to fix some breaking changes (Sku definition conflict between v2 and v3, exception to use ErrorResponse rather than ErrorContract): Azure/azure-rest-api-specs#14839 . These breaking changes have been approved.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answ...
Commit history page: https://github.com/Azure/azure-rest-api-specs/commits/master/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-04-01-preview
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draftmode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]orAzure.ResourceManager.[RP]Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new servicelabel and/or contact assigned reviewer.If the check fails at the
Verify Code Generationstep, please ensure:generate.ps1/cmdto generate this PR instead of callingautorestdirectly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.