Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to enable live testing in sovereign clouds for multiple services #21436

Draft
wants to merge 91 commits into
base: main
Choose a base branch
from

Conversation

zedy-wj
Copy link
Member

@zedy-wj zedy-wj commented May 28, 2021

We are running live Tests against other clouds like US Gov and Azure China Cloud. The goal is to check whether new azure sdk package work with other clouds or not.

Using this RR to trace and fix issues we encounter in the tests. Will close it once we finish all the tests and send PR per services.

Updated list:
Text analytics
Storage account
Form recognizer

@ghost ghost added App Configuration Azure.ApplicationModel.Configuration Cognitive - Form Recognizer Cognitive - Text Analytics Storage Storage Service (Queues, Blobs, Files) customer-reported Issues that are reported by GitHub users external to the Azure organization. labels May 28, 2021
@ghost
Copy link

ghost commented May 28, 2021

Thank you for your contribution @zedy-wj! We will review the pull request and get back to you soon.

@ghost ghost added the Community Contribution Community members are working on the issue label May 28, 2021
sdk/storage/tests.yml Outdated Show resolved Hide resolved
@jsquire jsquire requested a review from benbp May 28, 2021 13:08
sdk/storage/tests.yml Outdated Show resolved Hide resolved
sdk/storage/tests.yml Outdated Show resolved Hide resolved
sdk/storage/tests.yml Outdated Show resolved Hide resolved
@benbp
Copy link
Member

benbp commented Jun 4, 2021

Looks good from a config standpoint. @jsquire can you weigh in again and/or route for review on the code changes?

@jsquire jsquire self-requested a review June 4, 2021 21:14
@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. Service Attention Workflow: This issue is responsible by Azure service team. test-enhancement labels Jun 4, 2021
@check-enforcer
Copy link

check-enforcer bot commented Jun 8, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Nov 7, 2022
Added new virtualNetwork property to load balancer backend address pool (Azure#21436)
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Nov 7, 2022
Added new virtualNetwork property to load balancer backend address pool (Azure#21436)
zedy and others added 23 commits November 29, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Configuration Azure.ApplicationModel.Configuration Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer Cognitive - Text Analytics Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Service Attention Workflow: This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files) test-enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants