TelemetryItem.Time format to keep time precision #20476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangeg
requested review from
cijothomas,
rajkumar-rangaraj,
reyang and
TimothyMothra
as code owners
ghost
added
the
customer-reported
|
Thank you for your contribution @mangeg! We will review the pull request and get back to you soon. |
ghost
added
the
Community Contribution
ghost
added
the
no-recent-activity
|
Hi @mangeg. Thank you, for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
reyang
reviewed
Jun 18, 2021
sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/TelemetryPartA.cs
Outdated
Show resolved
Hide resolved
ghost
removed
the
no-recent-activity
reyang
reviewed
Jun 18, 2021
sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/TelemetryPartA.cs
Outdated
Show resolved
Hide resolved
reyang
approved these changes
Jun 18, 2021
There was a problem hiding this comment.
LGTM with one suggestion https://github.com/Azure/azure-sdk-for-net/pull/20476/files#r654660142.
Co-authored-by: Reiley Yang <reyang@microsoft.com>
reyang
reviewed
Jun 18, 2021
sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/TelemetryPartA.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Reiley Yang <reyang@microsoft.com>
|
Appreciate your contribution @mangeg! 🥂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20475