Support #if SNIPPET in snippets

[pakrym]

It's closer to C# syntax, can be used to verify that snippets still build after replacement and I can type it without having to consult the doc.

[pakrym]

If we decide to do this I'll update all existing snippets and remove the commend syntax.

[christothes]

Nice!

[heaths]

I like this. It should also help the occasional reformatting problems where VS wants to put /*@@*/ on it's own line and, if not caught, screws up the testable sample/snippet. At some point recently, too, VS seems to have stopped graying out ifdef'd out code and still provides IntelliSense, which helps writing syntactically correct snippet-only code.

[maririos]

@tg-msft once opened this issue => #8539
1y 1/2 later it is getting done!!

[pakrym]

Fixes: #8539

[pakrym]

If we decide to do this I'll update all existing snippets and remove the commend syntax.

Maybe not, there are a LOT of them. I might ask service owners to clean up their samples.

[maririos]

Maybe not, there are a LOT of them. I might ask service owners to clean up their samples.

Feel free to create issues per library and we can track the progress in the Eng Excellence epic.

[tg-msft]

This is great. A couple of questions:

• Will refactoring work in the #if SNIPPET branch?
• Should we file a work item to schedule a weekly build with -d SNIPPET to make sure all the code that doesn't run still compiles?

[pakrym]

Will refactoring work in the #if SNIPPET branch?

No, unfortunately, Roslyn treats the text in disabled branches as absent from the syntax/semantic tree.

Should we file a work item to schedule a weekly build with -d SNIPPET to make sure all the code that doesn't run still compiles?

Will do.

[pakrym]

Filed: #20431 #20432