Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Commit - Bring ModelRepository Project to the mono repo #18706

Merged
merged 5 commits into from
Feb 12, 2021
Merged

Initial Commit - Bring ModelRepository Project to the mono repo #18706

merged 5 commits into from
Feb 12, 2021

Conversation

azabbasi
Copy link
Contributor

No description provided.

azabbasi
azabbasi commented Feb 11, 2021
View reviewed changes
sdk/modelsrepository/Azure.Iot.ModelsRepository/src/Fetchers/LocalModelFetcher.cs

namespace Azure.Iot.ModelsRepository.Fetchers
{
internal class LocalModelFetcher : IModelFetcher
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marked this and the RemoteModelFetcher as internal

azabbasi
azabbasi commented Feb 11, 2021
View reviewed changes
sdk/modelsrepository/Azure.Iot.ModelsRepository/src/RepositoryHandler.cs

namespace Azure.Iot.ModelsRepository
{
internal class RepositoryHandler
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marked this as internal

azabbasi
azabbasi commented Feb 11, 2021
View reviewed changes
sdk/modelsrepository/Azure.Iot.ModelsRepository/src/ResolverClient.cs
/// <summary>
/// Evaluates whether an input <paramref name="dtmi"/> is valid.
/// </summary>
public static bool IsValidDtmi(string dtmi) => DtmiConventions.IsDtmi(dtmi);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marked this and all other methods that did not have instance field access as static

azabbasi
azabbasi commented Feb 11, 2021
View reviewed changes
sdk/modelsrepository/Azure.Iot.ModelsRepository/src/ResolverClientOptions.cs
/// The versions of Azure Digital Twins supported by this client
/// library.
/// </summary>
public enum ServiceVersion
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be ignored for now, we need to have a discussion about this since there is no backing service with different API versions.
Will bring it up during the meeting with SDK rep

azabbasi
azabbasi commented Feb 11, 2021
View reviewed changes
sdk/modelsrepository/Azure.Iot.ModelsRepository/src/ResolverClientOptions.cs
/// making requests.
/// </param>
/// <param name="resolutionOption">The dependency processing options.</param>
public ResolverClientOptions(ServiceVersion version = LatestVersion, DependencyResolutionOption resolutionOption = DependencyResolutionOption.Enabled)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same goes for the constructor.

azabbasi
azabbasi commented Feb 11, 2021
View reviewed changes
sdk/modelsrepository/Azure.Iot.ModelsRepository/src/ResolverClientOptions.cs
}

/// <summary>
/// The dependency processing options.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments can use some polishing. Will go over those in a future PR

azabbasi
azabbasi commented Feb 11, 2021
View reviewed changes
sdk/modelsrepository/Azure.Iot.ModelsRepository/src/ResolverEventSource.cs
using System;
using System.Diagnostics.Tracing;

namespace Azure.Iot.ModelsRepository
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss these during our meeting today with the SDK rep

azabbasi
azabbasi commented Feb 11, 2021
View reviewed changes
sdk/modelsrepository/Azure.Iot.ModelsRepository/tests/TestHelpers.cs
throw new ArgumentException();
}

public static string TestDirectoryPath => Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this to work with the track 2 folder structure.

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny
Copy link
Contributor

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny
Copy link
Contributor

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny
Copy link
Contributor

/azp run net - modelrepository - ci

@mitchdenny
Copy link
Contributor

/azp run net - modelsrepository - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mitchdenny
Copy link
Contributor

/azp run net - modelsrepository - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@azabbasi
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@azabbasi
Copy link
Contributor Author

/azp run net - modelsrepository - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@azabbasi azabbasi changed the base branch from master to feature/modelsRepo February 12, 2021 00:26
@mitchdenny
Copy link
Contributor

@azabbasi because your branch does not conform to feature/* it isn't triggering (because you are working on a feature branch. I had to trigger it manually via devops). Generally you are better off working off a fork and submitting a PR from there.

@azabbasi azabbasi merged commit 01e199e into feature/modelsRepo Feb 12, 2021
@azabbasi azabbasi deleted the feature/modelRepo/azabbasi branch February 12, 2021 00:37
azabbasi added a commit that referenced this pull request Feb 25, 2021
@azabbasi
(modelsRepo): Initial commit: Azure.Iot.ModelsRepository (#18998)
733e79a 
* Initial Commit - Bring ModelRepository Project to the mono repo (#18706)
* Use resx file and update formattings.
* Add client diagnostics - Add sync APIs to RemoteFetcher and LocalFetcher (#18807)
* Add async methods to the ResolverClient (#18814)
* Add support for recorded tests. (#18836)
* Add support for recorded tests.
* Make strings constants
* Update file names to include plural models
* Refactor RepositoryHandler and ResolverClient (#18857)
* Refactor ModelQuery (#18843)
* Refactor ModelQuery.
* Combine constant files.
* Rename Client to ModelsRepoClient (#18862)
* Remove ResolverException in favor of RequestFailedException (#18874)
* Remove ResolverException in favor of RequestFailedException. Adds more docstrings.
* Rename Repo to Repository and minor changes / Import samples project (#18986)
* Format changes/Remove resx file.
* Add first draft of readme. Add comment for dtmi validation. (#18987)
* Add comment for dtmi validation.
* Fix links.
* Add diagnostic event info.
* Source link specifically pointing to 'src' folder.
* Use fluent assertion
* Use playback as default
* fix Links and root service directory casing
Co-authored-by: Paymaun <Paymaunh@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digimaun digimaun digimaun left review comments

@drwill-ms drwill-ms drwill-ms approved these changes

@AlexGhiondea AlexGhiondea Awaiting requested review from AlexGhiondea

@danieljurek danieljurek Awaiting requested review from danieljurek

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@azabbasi @mitchdenny @drwill-ms @digimaun