Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed Reality Authentication: This change builds and tests the shared code #18397

Merged
3 commits merged into from
Feb 5, 2021

Commits on Feb 3, 2021

  1. Added a project to build shared code

      - This change adds a project file to build the Mixed Reality Authentication shared code to ensure it stays healthy.
      - It took a while to figure out how to add a project that wasn't going to be packaged and shipped, but could also access shared code and what not. You'll see me defining the `AzureCoreSharedSources` property manually because that property is only set for official client libraries which have certain criteria like starting with "Azure.".
    Craig Treasure committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    f2d3c2f View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2021

  1. Moved test project

    Craig Treasure committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    67bc005 View commit details
    Browse the repository at this point in the history
  2. Added Azure Mixed Reality Authentication shared code tests

      - This change adds a new Share.Azure.MixedReality.Authentication.Tests project to test the shared code. I did find 1 bug that presented when compiling with .NET 5.0 due to better nullable annotations. I had to pull the shared code in as source because I couldn't get `InternalsVisisbleTo` to work in this repo.
    Craig Treasure committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    4c9f9ce View commit details
    Browse the repository at this point in the history